Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1819973004: [NaCl SDK] Update smoothlife build to use webports (Closed)

Created:
4 years, 9 months ago by binji
Modified:
4 years, 9 months ago
Reviewers:
bradnelson
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Update smoothlife build to use webports BUG=none R=bradnelson@chromium.org Committed: https://crrev.com/e090801aec0b352fc3e8cabf58d278584d6b60df Cr-Commit-Position: refs/heads/master@{#382630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M native_client_sdk/src/gonacl_appengine/src/smoothlife/build.sh View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
binji
4 years, 9 months ago (2016-03-22 17:25:25 UTC) #1
bradnelson
lgtm
4 years, 9 months ago (2016-03-22 17:27:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819973004/1
4 years, 9 months ago (2016-03-22 17:27:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 19:18:52 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 19:21:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e090801aec0b352fc3e8cabf58d278584d6b60df
Cr-Commit-Position: refs/heads/master@{#382630}

Powered by Google App Engine
This is Rietveld 408576698