Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1819953002: Merge M50: "Cleanup MediaCodecUtil::GetDefaultCodecName()." (Closed)

Created:
4 years, 9 months ago by DaleCurtis
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Merge M50: "Cleanup MediaCodecUtil::GetDefaultCodecName()." There's no need to build an entire list of codecs and transport that across JNI when we always want the first one in the list. Notably this reduces the cost of GpuChildThread::OnInitialize() by over 400ms on an N5 running Marshmallow (450.208ms vs 39.64ms)! The reduction comes from VideoEncodeAccelerator no longer creating ~3 MediaCodec instances to determine the codec name during the call to VideoEncodeAccelerator::GetSupportedProfiles() during child thread startup. I suspect this will translate into real GPU process startup improvements. BUG=594814 TEST=codec lists match before after on KitKat below and above. Review URL: https://codereview.chromium.org/1805163002 Cr-Commit-Position: refs/heads/master@{#381805} (cherry picked from commit 5c1bee20afe6113087fc9a5781b5773a8894bbd4) Committed: https://chromium.googlesource.com/chromium/src/+/5d1be6b220032081d607aeff1a97a686302dc284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -228 lines) Patch
M media/base/android/java/src/org/chromium/media/MediaCodecUtil.java View 6 chunks +49 lines, -129 lines 0 comments Download
M media/base/android/media_codec_util.cc View 4 chunks +17 lines, -99 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years, 9 months ago (2016-03-21 18:07:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5d1be6b220032081d607aeff1a97a686302dc284.

Powered by Google App Engine
This is Rietveld 408576698