Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1819943002: Measure usage of IDBFactory.webkitGetDatabaseNames() (Closed)

Created:
4 years, 9 months ago by jsbell
Modified:
4 years, 9 months ago
Reviewers:
philipj_slow, Mark P
CC:
chromium-reviews, blink-reviews, jsbell+idb_chromium.org, asvitkine+watch_chromium.org, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Measure usage of IDBFactory.webkitGetDatabaseNames() Non-standard method; it would be nice to deprecate/remove this if usage is low enough, or push for standardization if usage is too high. BUG=596543 R=mpearson@chromium.com,philipj@opera.com Committed: https://crrev.com/a7608cf660f98528d51e73ad780b774b67258cd1 Cr-Commit-Position: refs/heads/master@{#382517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBFactory.idl View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
jsbell
mpearson@ - can you please take a peek?
4 years, 9 months ago (2016-03-21 18:32:28 UTC) #3
Mark P
histograms.xml lgtm
4 years, 9 months ago (2016-03-21 19:18:39 UTC) #4
jsbell
philipj@ - can you OWNERS review for Source/core/frame? (and CQ if LG?)
4 years, 9 months ago (2016-03-21 19:27:26 UTC) #8
philipj_slow
lgtm
4 years, 9 months ago (2016-03-22 06:22:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819943002/1
4 years, 9 months ago (2016-03-22 06:22:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 06:28:06 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 06:29:42 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7608cf660f98528d51e73ad780b774b67258cd1
Cr-Commit-Position: refs/heads/master@{#382517}

Powered by Google App Engine
This is Rietveld 408576698