Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: chrome/test/base/tracing_browsertest.cc

Issue 1819883002: Disabling flaky SingleProcessTracingBrowserTest.TestMemoryInfra (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/base/tracing.h" 5 #include "chrome/test/base/tracing.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/single_thread_task_runner.h" 10 #include "base/single_thread_task_runner.h"
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 NEW_FOREGROUND_TAB, ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION); 157 NEW_FOREGROUND_TAB, ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
158 ASSERT_NO_FATAL_FAILURE(ExecuteJavascriptOnCurrentTab()); 158 ASSERT_NO_FATAL_FAILURE(ExecuteJavascriptOnCurrentTab());
159 ui_test_utils::NavigateToURLWithDisposition(browser(), url2, 159 ui_test_utils::NavigateToURLWithDisposition(browser(), url2,
160 NEW_FOREGROUND_TAB, ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION); 160 NEW_FOREGROUND_TAB, ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
161 ASSERT_NO_FATAL_FAILURE(ExecuteJavascriptOnCurrentTab()); 161 ASSERT_NO_FATAL_FAILURE(ExecuteJavascriptOnCurrentTab());
162 EXPECT_TRUE(WaitForWatchEvent(no_timeout)); 162 EXPECT_TRUE(WaitForWatchEvent(no_timeout));
163 ASSERT_TRUE(EndTracing(&json_events)); 163 ASSERT_TRUE(EndTracing(&json_events));
164 } 164 }
165 165
166 // Multi-process mode. 166 // Multi-process mode.
167 IN_PROC_BROWSER_TEST_F(TracingBrowserTest, TestMemoryInfra) { 167 // Flaky on win and Linux: https://crbug.com/594884.
168 IN_PROC_BROWSER_TEST_F(TracingBrowserTest, DISABLED_TestMemoryInfra) {
168 PerformDumpMemoryTestActions(); 169 PerformDumpMemoryTestActions();
169 } 170 }
170 171
171 // Single-process mode. 172 // Single-process mode.
172 // Flaky (leaking) on linux_chromium_asan_rel_ng: https://crbug.com/585026 173 // Flaky (leaking) on linux_chromium_asan_rel_ng: https://crbug.com/585026
173 // and Windows https://crbug.com/594884 174 // and Windows https://crbug.com/594884
174 #if defined(ADDRESS_SANITIZER) || defined(OS_WIN) 175 #if defined(ADDRESS_SANITIZER) || defined(OS_WIN)
175 #define MAYBE_TestMemoryInfra DISABLED_TestMemoryInfra 176 #define MAYBE_TestMemoryInfra DISABLED_TestMemoryInfra
176 #else 177 #else
177 #define MAYBE_TestMemoryInfra TestMemoryInfra 178 #define MAYBE_TestMemoryInfra TestMemoryInfra
178 #endif 179 #endif
179 IN_PROC_BROWSER_TEST_F(SingleProcessTracingBrowserTest, MAYBE_TestMemoryInfra) { 180 IN_PROC_BROWSER_TEST_F(SingleProcessTracingBrowserTest, MAYBE_TestMemoryInfra) {
180 PerformDumpMemoryTestActions(); 181 PerformDumpMemoryTestActions();
181 } 182 }
182 183
183 } // namespace 184 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698