Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1819853004: fix release build vulkan (Closed)

Created:
4 years, 9 months ago by egdaniel
Modified:
4 years, 9 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/gpu/vk/GrVkGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkProgram.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkProgram.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
egdaniel
4 years, 9 months ago (2016-03-21 21:06:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819853004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819853004/1
4 years, 9 months ago (2016-03-21 21:06:38 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-21 21:06:40 UTC) #6
jvanverth1
lgtm
4 years, 9 months ago (2016-03-21 21:23:16 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 21:24:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2cab66be9c47660da6a2cc94b469c14d5bed958e

Powered by Google App Engine
This is Rietveld 408576698