Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1819853003: QUIC - extend QuicInMemoryCache so that simple server can do server push. (Closed)

Created:
4 years, 9 months ago by Buck
Modified:
4 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - extend QuicInMemoryCache so that simple server can do server push. Merge internal change: 117591398 BUG= Committed: https://crrev.com/80c695397c352cefbd00f127e3f1bee2626cf3d2 Cr-Commit-Position: refs/heads/master@{#382458}

Patch Set 1 #

Patch Set 2 : attempt to fix windows compile error #

Patch Set 3 : second attempt to fix windows compile #

Patch Set 4 : windows compile #3 #

Patch Set 5 : another try for FilePath compile #

Patch Set 6 : fix asan detected bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -63 lines) Patch
A net/data/quic_in_memory_cache_data_with_push/quic-datatesturl.com/favicon.ico View Binary file 0 comments Download
A + net/data/quic_in_memory_cache_data_with_push/quic-datatesturl.com/index.html View 1 chunk +2 lines, -1 line 0 comments Download
A + net/data/quic_in_memory_cache_data_with_push/quic-datatesturl.com/index2.html View 1 chunk +3 lines, -1 line 0 comments Download
A net/data/quic_in_memory_cache_data_with_push/quic-datatesturl.com/kitten-1.jpg View Binary file 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 1 2 3 4 5 3 chunks +56 lines, -4 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 1 2 3 4 5 8 chunks +126 lines, -47 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache_test.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.cc View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Buck
4 years, 9 months ago (2016-03-21 21:32:12 UTC) #3
Ryan Hamilton
LGTM, though you might want to ping quic merge duty to make sure they know ...
4 years, 9 months ago (2016-03-21 21:42:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819853003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819853003/100001
4 years, 9 months ago (2016-03-21 23:48:44 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 9 months ago (2016-03-22 00:35:01 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 00:36:44 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/80c695397c352cefbd00f127e3f1bee2626cf3d2
Cr-Commit-Position: refs/heads/master@{#382458}

Powered by Google App Engine
This is Rietveld 408576698