Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1819833002: Use exact instruction names in the SSA tracer. (Closed)

Created:
4 years, 9 months ago by Kevin Millikin (Google)
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use exact instruction names in the SSA tracer. Before the mapping from HInstruction names to printed representations used by the tracer was arbitrary. Change it to use the HInstruction name with a colon separating the arguments from the instruction name. The first colon on the line is recognized by the tool as delimiting the opcode. Seeing the precise structure of the IR is more important than having human-writable surface syntax. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/6efe664788663055edbaf32aacb62733472d1aaa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -67 lines) Patch
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 12 chunks +70 lines, -67 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
4 years, 9 months ago (2016-03-21 10:27:23 UTC) #2
sra1
lgtm
4 years, 9 months ago (2016-03-21 12:11:09 UTC) #3
Kevin Millikin (Google)
4 years, 9 months ago (2016-03-21 12:25:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6efe664788663055edbaf32aacb62733472d1aaa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698