src/ia32/code-stubs-ia32.cc - Issue 1819813002: [es6] Faster implementation of OrdinaryHasInstance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 1819813002: [es6] Faster implementation of OrdinaryHasInstance. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address my own comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/code-stubs-ia32.cc

diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc

index ff634efa1b99478fcdbcc9ce065ea736609717d6..f735adab5eb7b02bda1372b6e7ed1d87ad2eb8c2 100644

--- a/src/ia32/code-stubs-ia32.cc

+++ b/src/ia32/code-stubs-ia32.cc

@@ -2213,7 +2213,8 @@ void InstanceOfStub::Generate(MacroAssembler* masm) {

__ Push(object);

__ Push(function);

__ PushReturnAddressFrom(scratch);

- __ TailCallRuntime(Runtime::kInstanceOf);

+ __ TailCallRuntime(is_es6_instanceof() ? Runtime::kOrdinaryHasInstance

+ : Runtime::kInstanceOf);

}