Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 18198003: Abort optimization when debugger is turned on. (Closed)

Created:
7 years, 5 months ago by Yang
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Abort optimization when debugger is turned on. BUG=v8:2751 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15378

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -62 lines) Patch
M src/compiler.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/debug.cc View 1 chunk +22 lines, -5 lines 0 comments Download
M src/objects.cc View 4 chunks +8 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-debug-deopt-while-recompile.js View 2 chunks +41 lines, -27 lines 0 comments Download
A + test/mjsunit/regress/regress-opt-after-debug-deopt.js View 2 chunks +29 lines, -26 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Please take a look.
7 years, 5 months ago (2013-06-28 11:23:24 UTC) #1
Jakob Kummerow
lgtm
7 years, 5 months ago (2013-06-28 11:34:04 UTC) #2
Yang
7 years, 5 months ago (2013-06-28 11:35:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r15378 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698