[Crankshaft] Check that both sides of test context are connected.

[Crankshaft] Check that both sides of test context are connected.

R=bmeurer@chromium.org

Committed: https://crrev.com/8872ec5eab7041d358a0a79954fbd3711d4953f5
Cr-Commit-Position: refs/heads/master@{#34918}

[Jarin, 2016-03-21 05:52:36]

Could you take a look, please? (Not sure about the DCHECKs, maybe they should be
CHECKs.)

[Benedikt Meurer, 2016-03-21 05:56:42]

LGTM with nit.

https://codereview.chromium.org/1819793002/diff/1/src/crankshaft/hydrogen.cc
File src/crankshaft/hydrogen.cc (right):

https://codereview.chromium.org/1819793002/diff/1/src/crankshaft/hydrogen.cc#...
src/crankshaft/hydrogen.cc:4776: DCHECK(cond_true->HasPredecessor());
Please add a comment and turn this into a CHECK.

[Jarin, 2016-03-21 06:08:46]

https://codereview.chromium.org/1819793002/diff/1/src/crankshaft/hydrogen.cc
File src/crankshaft/hydrogen.cc (right):

https://codereview.chromium.org/1819793002/diff/1/src/crankshaft/hydrogen.cc#...
src/crankshaft/hydrogen.cc:4776: DCHECK(cond_true->HasPredecessor());
On 2016/03/21 05:56:42, Benedikt Meurer wrote:
> Please add a comment and turn this into a CHECK.

Done.

[Jarin, 2016-03-21 06:09:05]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2016-03-21 06:09:06]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1819793002/#ps20001
(title: "DCHECK -> CHECK, comment")

[commit-bot: I haz the power, 2016-03-21 06:09:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819793002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819793002/20001

[commit-bot: I haz the power, 2016-03-21 06:29:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-21 06:31:43]

Description was changed from

==========
[Crankshaft] Check that both sides of test context are connected.

R=bmeurer@chromium.org
==========

to

==========
[Crankshaft] Check that both sides of test context are connected.

R=bmeurer@chromium.org

Committed: https://crrev.com/8872ec5eab7041d358a0a79954fbd3711d4953f5
Cr-Commit-Position: refs/heads/master@{#34918}
==========

[commit-bot: I haz the power, 2016-03-21 06:31:44]

Patchset 2 (id:??) landed as
https://crrev.com/8872ec5eab7041d358a0a79954fbd3711d4953f5
Cr-Commit-Position: refs/heads/master@{#34918}