Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1819783002: Blink Platform UnitBezier: Implement Slope and Range methods. (Closed)

Created:
4 years, 9 months ago by loyso (OOO)
Modified:
4 years, 9 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, esprehn, f(malita), fs, gyuyoung2, kinuko+watch, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink Platform UnitBezier: Implement Slope and Range methods. We want to align blink::UnitBezier implementation with gfx::CubicBezier. Basically, blink::UnitBezier is a super set for gfx::CubicBezier. In next CLs: 1) Merge blink::UnitBezier onto gfx::CubicBezier (including unit tests and rewriting to chromium style). gfx::CubicBezier is located at very low level and it is visible for all subsystems. 2) Make blink::UnitBezier a thin wrapper around gfx::CubicBezier with all the calls inlined. Note, that we are allowed to include gfx/geometry in blink now (same as for cc/). Note, we will deal with std::numeric_limits<double>::epsilon separately here: http://crbug.com/458917 Disclaimer: - Code is adapted from ui/gfx/geometry/cubic_bezier.cc - Tests are adapted from ui/gfx/geometry/cubic_bezier_unittest.cc BUG=577016 Committed: https://crrev.com/1c4eeac676562ac084da146ffad80e78d56c0b62 Cr-Commit-Position: refs/heads/master@{#382756}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Address codereview issues. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -70 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/animation/TimingFunction.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/animation/TimingFunctionTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/animation/UnitBezier.h View 1 4 chunks +52 lines, -48 lines 0 comments Download
A third_party/WebKit/Source/platform/animation/UnitBezier.cpp View 1 1 chunk +113 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/animation/UnitBezierTest.cpp View 2 chunks +116 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
loyso (OOO)
vollick@, blink_platform.gypi review please!
4 years, 9 months ago (2016-03-21 05:40:39 UTC) #3
loyso (OOO)
https://codereview.chromium.org/1819783002/diff/1/third_party/WebKit/Source/platform/animation/UnitBezier.cpp File third_party/WebKit/Source/platform/animation/UnitBezier.cpp (right): https://codereview.chromium.org/1819783002/diff/1/third_party/WebKit/Source/platform/animation/UnitBezier.cpp#newcode9 third_party/WebKit/Source/platform/animation/UnitBezier.cpp:9: const double UnitBezier::kBezierEpsilon = 1e-7; Copied from cubic_bezier.cc
4 years, 9 months ago (2016-03-21 06:02:48 UTC) #9
alancutter (OOO until 2018)
If the intention is ultimately to put all the logic into gfx::CubicBezier and make blink::UnitBezier ...
4 years, 9 months ago (2016-03-21 06:54:11 UTC) #12
alancutter (OOO until 2018)
I understand now that the methods being moved into blink::UnitBezier are actually being rewritten in ...
4 years, 9 months ago (2016-03-21 07:04:58 UTC) #13
alancutter (OOO until 2018)
lgtm with nits. https://codereview.chromium.org/1819783002/diff/1/third_party/WebKit/Source/platform/animation/UnitBezier.h File third_party/WebKit/Source/platform/animation/UnitBezier.h (right): https://codereview.chromium.org/1819783002/diff/1/third_party/WebKit/Source/platform/animation/UnitBezier.h#newcode43 third_party/WebKit/Source/platform/animation/UnitBezier.h:43: static const double kBezierEpsilon; This should ...
4 years, 9 months ago (2016-03-21 07:12:56 UTC) #14
loyso (OOO)
https://codereview.chromium.org/1819783002/diff/1/third_party/WebKit/Source/platform/animation/UnitBezier.h File third_party/WebKit/Source/platform/animation/UnitBezier.h (right): https://codereview.chromium.org/1819783002/diff/1/third_party/WebKit/Source/platform/animation/UnitBezier.h#newcode43 third_party/WebKit/Source/platform/animation/UnitBezier.h:43: static const double kBezierEpsilon; On 2016/03/21 07:12:56, alancutter wrote: ...
4 years, 9 months ago (2016-03-22 03:12:50 UTC) #15
dstockwell
lgtm
4 years, 9 months ago (2016-03-22 03:21:34 UTC) #16
Ian Vollick
On 2016/03/22 03:21:34, dstockwell wrote: > lgtm lgtm.
4 years, 9 months ago (2016-03-22 23:37:07 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819783002/20001
4 years, 9 months ago (2016-03-23 00:28:42 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 01:17:59 UTC) #22
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 01:19:20 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c4eeac676562ac084da146ffad80e78d56c0b62
Cr-Commit-Position: refs/heads/master@{#382756}

Powered by Google App Engine
This is Rietveld 408576698