Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: ui/views/controls/button/label_button.cc

Issue 1819753003: Allow various font weights in gfx. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a lost comment and modify a render text unittest to not test black because of test env font con… Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/text_constants.h ('k') | ui/views/controls/button/label_button_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/button/label_button.cc
diff --git a/ui/views/controls/button/label_button.cc b/ui/views/controls/button/label_button.cc
index 8c13cf00079a77fd6f6a80664e590b9e06a842af..69d7a6bb4ad43636ee4560c86a724aa38a54b3f5 100644
--- a/ui/views/controls/button/label_button.cc
+++ b/ui/views/controls/button/label_button.cc
@@ -32,6 +32,21 @@ namespace {
// The default spacing between the icon and text.
const int kSpacing = 5;
+gfx::Font::Weight GetValueBolderThan(gfx::Font::Weight weight) {
+ if (weight < gfx::Font::Weight::BOLD)
+ return gfx::Font::Weight::BOLD;
+ switch (weight) {
+ case gfx::Font::Weight::BOLD:
+ return gfx::Font::Weight::EXTRA_BOLD;
+ case gfx::Font::Weight::EXTRA_BOLD:
+ case gfx::Font::Weight::BLACK:
+ return gfx::Font::Weight::BLACK;
+ default:
+ NOTREACHED();
+ }
+ return gfx::Font::Weight::INVALID;
+}
+
const gfx::FontList& GetDefaultNormalFontList() {
static base::LazyInstance<gfx::FontList>::Leaky font_list =
LAZY_INSTANCE_INITIALIZER;
@@ -44,11 +59,14 @@ const gfx::FontList& GetDefaultBoldFontList() {
static base::LazyInstance<gfx::FontList>::Leaky font_list =
LAZY_INSTANCE_INITIALIZER;
- if ((font_list.Get().GetFontStyle() & gfx::Font::BOLD) == 0) {
- font_list.Get() = font_list.Get().
- DeriveWithStyle(font_list.Get().GetFontStyle() | gfx::Font::BOLD);
- DCHECK_NE(font_list.Get().GetFontStyle() & gfx::Font::BOLD, 0);
- }
+
+ static const gfx::Font::Weight default_bold_weight =
+ font_list.Get().GetFontWeight();
+
+ font_list.Get() = font_list.Get().DeriveWithWeight(
+ GetValueBolderThan(default_bold_weight));
+ DCHECK_GE(font_list.Get().GetFontWeight(), gfx::Font::Weight::BOLD);
+
return font_list.Get();
}
@@ -165,8 +183,8 @@ const gfx::FontList& LabelButton::GetFontList() const {
void LabelButton::SetFontList(const gfx::FontList& font_list) {
cached_normal_font_list_ = font_list;
if (PlatformStyle::kDefaultLabelButtonHasBoldFont) {
- cached_bold_font_list_ =
- font_list.DeriveWithStyle(font_list.GetFontStyle() | gfx::Font::BOLD);
+ cached_bold_font_list_ = font_list.DeriveWithWeight(
+ GetValueBolderThan(font_list.GetFontWeight()));
if (is_default_) {
label_->SetFontList(cached_bold_font_list_);
return;
« no previous file with comments | « ui/gfx/text_constants.h ('k') | ui/views/controls/button/label_button_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698