Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2054)

Unified Diff: ui/gfx/font_render_params_linux_unittest.cc

Issue 1819753003: Allow various font weights in gfx. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a lost comment and modify a render text unittest to not test black because of test env font con… Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/font_render_params_linux.cc ('k') | ui/gfx/font_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/font_render_params_linux_unittest.cc
diff --git a/ui/gfx/font_render_params_linux_unittest.cc b/ui/gfx/font_render_params_linux_unittest.cc
index 63601d1b3b563af90d9b42b2eca20021a3d906ae..1097d978be92102ed95372c29a9ccf1486522e24 100644
--- a/ui/gfx/font_render_params_linux_unittest.cc
+++ b/ui/gfx/font_render_params_linux_unittest.cc
@@ -29,11 +29,11 @@ class TestFontDelegate : public LinuxFontDelegate {
FontRenderParams GetDefaultFontRenderParams() const override {
return params_;
}
- void GetDefaultFontDescription(
- std::string* family_out,
- int* size_pixels_out,
- int* style_out,
- FontRenderParams* params_out) const override {
+ void GetDefaultFontDescription(std::string* family_out,
+ int* size_pixels_out,
+ bool* italic_out,
+ Font::Weight* weight_out,
+ FontRenderParams* params_out) const override {
NOTIMPLEMENTED();
}
@@ -194,19 +194,21 @@ TEST_F(FontRenderParamsTest, Style) {
EXPECT_EQ(FontRenderParams::SUBPIXEL_RENDERING_RGB,
params.subpixel_rendering);
- query.style = Font::BOLD;
+ query.weight = Font::Weight::BOLD;
params = GetFontRenderParams(query, NULL);
EXPECT_EQ(FontRenderParams::HINTING_SLIGHT, params.hinting);
EXPECT_EQ(FontRenderParams::SUBPIXEL_RENDERING_NONE,
params.subpixel_rendering);
+ query.weight = Font::Weight::NORMAL;
query.style = Font::ITALIC;
params = GetFontRenderParams(query, NULL);
EXPECT_EQ(FontRenderParams::HINTING_NONE, params.hinting);
EXPECT_EQ(FontRenderParams::SUBPIXEL_RENDERING_RGB,
params.subpixel_rendering);
- query.style = Font::BOLD | Font::ITALIC;
+ query.weight = Font::Weight::BOLD;
+ query.style = Font::ITALIC;
params = GetFontRenderParams(query, NULL);
EXPECT_EQ(FontRenderParams::HINTING_NONE, params.hinting);
EXPECT_EQ(FontRenderParams::SUBPIXEL_RENDERING_NONE,
« no previous file with comments | « ui/gfx/font_render_params_linux.cc ('k') | ui/gfx/font_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698