chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h - Issue 1819753003: Allow various font weights in gfx.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

Issue 1819753003: Allow various font weights in gfx. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a lost comment and modify a render text unittest to not test black because of test env font con… Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

index 04a9f44710fb84857348a5aec276c0759b9cbfe7..b2fc27a0a59389db1371ab942404a77e53ecfad3 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h

@@ -125,11 +125,10 @@ class OmniboxViewMac : public OmniboxView,

// Helper to get the font to use in the field, exposed for the

// popup.

- // The style parameter specifies the new style for the font, and is a

- // bitmask of the values: BOLD, ITALIC and UNDERLINE (see ui/gfx/font.h).

- static NSFont* GetFieldFont(int style);

- static NSFont* GetLargeFont(int style);

- static NSFont* GetSmallFont(int style);

+ static NSFont* GetNormalFieldFont();

+ static NSFont* GetBoldFieldFont();

+ static NSFont* GetLargeFont();

+ static NSFont* GetSmallFont();

// If |resource_id| has a PDF image which can be used, return it.

// Otherwise return the PNG image from the resource bundle.