chrome/browser/extensions/api/file_system/request_file_system_dialog_view.cc - Issue 1819753003: Allow various font weights in gfx.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/file_system/request_file_system_dialog_view.cc

Issue 1819753003: Allow various font weights in gfx. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a lost comment and modify a render text unittest to not test black because of test env font con… Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/file_system/request_file_system_dialog_view.cc

diff --git a/chrome/browser/extensions/api/file_system/request_file_system_dialog_view.cc b/chrome/browser/extensions/api/file_system/request_file_system_dialog_view.cc

index ea1d716a6cecba5f8b40a0601e923d1bd604662b..409a007b13226e5211f2d2de5deaea073f9d4384 100644

--- a/chrome/browser/extensions/api/file_system/request_file_system_dialog_view.cc

+++ b/chrome/browser/extensions/api/file_system/request_file_system_dialog_view.cc

@@ -121,7 +121,7 @@ RequestFileSystemDialogView::RequestFileSystemDialogView(

views::StyledLabel* const label = new views::StyledLabel(message, nullptr);

views::StyledLabel::RangeStyleInfo bold_style;

- bold_style.font_style = gfx::Font::BOLD;

+ bold_style.weight = gfx::Font::Weight::BOLD;

DCHECK_EQ(2u, placeholder_offsets.size());

label->AddStyleRange(gfx::Range(placeholder_offsets[0],

« no previous file with comments | « ash/system/tray/tray_utils.cc ('k') | chrome/browser/ui/autofill/autofill_popup_controller_impl.cc » ('j') | no next file with comments »