Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: ui/gfx/font.h

Issue 1819753003: Allow various font weights in gfx. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes for review issues. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/font.h
diff --git a/ui/gfx/font.h b/ui/gfx/font.h
index b7a7f9da4bde09a46d90a5d22ff72562e5bfe7f9..c58a5b3428a427235e4db6a635f0dc8615d223e0 100644
--- a/ui/gfx/font.h
+++ b/ui/gfx/font.h
@@ -34,9 +34,21 @@ class GFX_EXPORT Font {
// The following constants indicate the font style.
enum FontStyle {
msw 2016/03/22 18:24:11 nit: it'd be nice to make this an enum class too,
Mikus 2016/03/23 17:53:21 Won't do in this CL.
NORMAL = 0,
- BOLD = 1,
- ITALIC = 2,
- UNDERLINE = 4,
+ ITALIC = 1,
+ UNDERLINE = 2,
+ };
+
+ enum class Weight {
+ INVALID = -1,
+ THIN = 100,
+ EXTRA_LIGHT = 200,
+ LIGHT = 300,
+ NORMAL = 400,
+ MEDIUM = 500,
+ SEMIBOLD = 600,
+ BOLD = 700,
+ EXTRA_BOLD = 800,
+ BLACK = 900,
};
// Creates a font with the default name and style.
@@ -64,8 +76,8 @@ class GFX_EXPORT Font {
// |size_delta| is the size in pixels to add to the current font. For example,
// a value of 5 results in a font 5 pixels bigger than this font.
// The style parameter specifies the new style for the font, and is a
- // bitmask of the values: BOLD, ITALIC and UNDERLINE.
- Font Derive(int size_delta, int style) const;
+ // bitmask of the values: ITALIC and UNDERLINE.
+ Font Derive(int size_delta, int style, gfx::Font::Weight weight) const;
// Returns the number of vertical pixels needed to display characters from
// the specified font. This may include some leading, i.e. height may be
@@ -74,6 +86,9 @@ class GFX_EXPORT Font {
// need to be revisited in the future.
int GetHeight() const;
+ // Returns the font weight.
+ gfx::Font::Weight GetWeight() const;
+
// Returns the baseline, or ascent, of the font.
int GetBaseline() const;
@@ -118,6 +133,9 @@ class GFX_EXPORT Font {
scoped_refptr<PlatformFont> platform_font_;
};
+GFX_EXPORT std::ostream& operator<<(std::ostream& stream,
msw 2016/03/22 18:24:10 Is this intentional/necessary?
Mikus 2016/03/23 17:53:21 Yes. Probably I should add an #ifndef NDEBUG aroun
+ const gfx::Font::Weight weight);
+
} // namespace gfx
#endif // UI_GFX_FONT_H_

Powered by Google App Engine
This is Rietveld 408576698