Allow various font weights in gfx.

chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h"
 
 #include <Carbon/Carbon.h>  // kVK_Return
 
 #include "base/mac/foundation_util.h"
 #include "base/metrics/histogram.h"
@@ skipping 1054 matching lines @@
     // If the text field has a field editor, it's the first responder, meaning
     // that it's already focused. makeFirstResponder: will select all, so only
     // call it if this behavior is desired.
     if (select_all || ![field_ currentEditor])
       [[field_ window] makeFirstResponder:field_];
     DCHECK_EQ([field_ currentEditor], [[field_ window] firstResponder]);
   }
 }
 
 // static
 NSFont* OmniboxViewMac::GetFieldFont(int style) {

[tapted, 2016/03/27 23:10:02]

Callers only ever pass in BOLD or NORMAL to this method. And callers of
Large/Small appear to always pass Normal.

Rather than mechanically updating the `int style` to a `gfx::Font::Weight` I
think it would be nicer to have methods:

OmniboxViewMac::GetNormalFieldFont();
OmniboxViewMac::GetBoldFieldFont();
OmniboxViewMac::GetLargeFont();
OmniboxViewMac::GetSmallFont();


Then since it's changing anyway (and it's silly to take a base font and "just
add one to it"). Instead of GetFontList(LargeFont).Derive(1), it should be

const int kOmniboxLargeFontSizeDelta = 9;
return ui::ResourceBundle::GetSharedInstance()
    .GetFontWithDelta(kOmniboxLargeFontSizeDelta).GetNativeFont();


(`9` is `ResourceBundle::kLargeFontDelta + 1` but there's no benefit in coupling
them together since "Large" doesn't have any semantic meaning of its own)

Do the same for Small/Base.

[Mikus, 2016/03/29 10:55:38]

Done.

   // This value should be kept in sync with InstantPage::InitializeFonts.
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
-  return rb.GetFontList(ui::ResourceBundle::BaseFont).Derive(1, style)
-      .GetPrimaryFont().GetNativeFont();
+  return rb.GetFontList(ui::ResourceBundle::BaseFont)
+      .Derive(1, style, gfx::Font::Weight::NORMAL)
+      .GetPrimaryFont()
+      .GetNativeFont();

[Peter Kasting, 2016/03/26 00:56:51]

Nit: Maybe:

namespace {

NSFont* GetFontForSizeAndStyle(ui::ResourceBundle::FontStyle size, int style) {
  return ui::ResourceBundle::GetSharedInstance().GetFontList(size)
      .Derive(1, style, gfx::Font::Weight::NORMAL)
      .GetPrimaryFont()
      .GetNativeFont();
}

}  // namespace

...

// static
NSFont* OmniboxViewMac::GetFieldFont(int style) {
  return GetFontForSizeAndStyle(ui::ResourceBundle::BaseFont, style);
}

...

[Mikus, 2016/03/29 10:55:38]

Not really needed anymore.

 }
 
 NSFont* OmniboxViewMac::GetLargeFont(int style) {
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   return rb.GetFontList(ui::ResourceBundle::LargeFont)
-      .Derive(1, style)
+      .Derive(1, style, gfx::Font::Weight::NORMAL)
       .GetPrimaryFont()
       .GetNativeFont();
 }
 
 NSFont* OmniboxViewMac::GetSmallFont(int style) {
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   return rb.GetFontList(ui::ResourceBundle::SmallFont)
-      .Derive(1, style)
+      .Derive(1, style, gfx::Font::Weight::NORMAL)
       .GetPrimaryFont()
       .GetNativeFont();
 }
 
 int OmniboxViewMac::GetOmniboxTextLength() const {
   return static_cast<int>(GetTextLength());
 }
 
 NSUInteger OmniboxViewMac::GetTextLength() const {
   return [field_ currentEditor] ?  [[[field_ currentEditor] string] length] :
                                    [[field_ stringValue] length];
 }
 
 bool OmniboxViewMac::IsCaretAtEnd() const {
   const NSRange selection = GetSelectedRange();
   return NSMaxRange(selection) == GetTextLength();
 }