Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1819753002: Remove unused VS2015 realloc heap mismatch suppression. (Closed)

Created:
4 years, 9 months ago by Derek Bruening
Modified:
4 years, 9 months ago
Reviewers:
brucedawson
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused VS2015 realloc heap mismatch suppression. The suppression was never hit on the bots, and I cannot reproduce it locally even running Dr. Memory builds prior to the several VS2015 fixes. If with the latest Dr. Memory it happens again in some environments, we would prefer to address it at the Dr. Memory level rather than with a Chromium suppression as it is general enough to affect external users. BUG=595792 TBR=brucedawson@chromium.org NOTRY=true Committed: https://crrev.com/fa7a7747d6f9cb16cda4e8caf946ef2e26cc894b Cr-Commit-Position: refs/heads/master@{#382226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M tools/valgrind/drmemory/suppressions.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Derek Bruening
4 years, 9 months ago (2016-03-20 17:22:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819753002/1
4 years, 9 months ago (2016-03-20 17:23:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-20 20:23:14 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-20 20:24:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa7a7747d6f9cb16cda4e8caf946ef2e26cc894b
Cr-Commit-Position: refs/heads/master@{#382226}

Powered by Google App Engine
This is Rietveld 408576698