cc/layers/picture_image_layer.cc - Issue 1819683002: Use sk_sp-based picture recording APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/picture_image_layer.cc

Issue 1819683002: Use sk_sp-based picture recording APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/picture_image_layer.cc

diff --git a/cc/layers/picture_image_layer.cc b/cc/layers/picture_image_layer.cc

index 05cbb0c331f1e53766709fca8e04dd3df54b704d..3c17c8c3bbae66f9607a31e4161e7e4793f89377 100644

--- a/cc/layers/picture_image_layer.cc

+++ b/cc/layers/picture_image_layer.cc

@@ -80,10 +80,8 @@ scoped_refptr<DisplayItemList> PictureImageLayer::PaintContentsToDisplayList(

// transparent images blend correctly.

canvas->drawImage(image_.get(), 0, 0);

- skia::RefPtr<SkPicture> picture =

- skia::AdoptRef(recorder.endRecordingAsPicture());

- display_list->CreateAndAppendItem<DrawingDisplayItem>(PaintableRegion(),

- std::move(picture));

+ display_list->CreateAndAppendItem<DrawingDisplayItem>(

+ PaintableRegion(), recorder.finishRecordingAsPicture());

display_list->Finalize();

return display_list;