Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1819673002: vm: Avoid list allocation for empty map literals (Closed)

Created:
4 years, 9 months ago by sra1
Modified:
4 years, 9 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

vm: Avoid list allocation for empty map literals. This reduces the number of _List(0) allocations in a dart2js compile by ~3%. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/30f3df8f2637ba91def56924a8b7e579e94a51e4

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M runtime/vm/parser.cc View 1 chunk +14 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sra1
4 years, 9 months ago (2016-03-19 23:40:24 UTC) #4
sra1
Changing reviewer to hausner
4 years, 9 months ago (2016-03-21 19:44:44 UTC) #6
hausner
lgtm
4 years, 9 months ago (2016-03-21 20:08:29 UTC) #7
sra1
4 years, 9 months ago (2016-03-22 17:34:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
30f3df8f2637ba91def56924a8b7e579e94a51e4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698