Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: scripts/slave/recipes/chromium_trybot.py

Issue 1819613002: Flip remaining chromium_gn bots to the chromium recipe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: update w/ review feedback, add deapply test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium_trybot.py
diff --git a/scripts/slave/recipes/chromium_trybot.py b/scripts/slave/recipes/chromium_trybot.py
index 848701495331c79dddfebdcd719bc7750e8b16fd..97de371ff786973b71d9a00ef3c66e7cd9120238 100644
--- a/scripts/slave/recipes/chromium_trybot.py
+++ b/scripts/slave/recipes/chromium_trybot.py
@@ -555,6 +555,24 @@ def GenTests(api):
api.step_data('compile (with patch)', retcode=1)
)
+ # Test that the component rev for v8 is correctly applied
+ # both on the initial checkout and after deapplying the patch.
+ yield (
+ api.test('compile_failure_with_component_rev') +
+ api.platform('linux', 64) +
+ props(mastername='tryserver.v8',
+ buildername='v8_linux_chromium_gn_rel') +
+ api.properties(revision='22135') +
+ api.override_step_data('read test spec', api.json.output({
+ 'V8 Linux GN': {
+ 'additional_compile_targets': ['base_unittests'],
+ },
+ })
+ ) +
+ suppress_analyze() +
+ api.step_data('compile (with patch)', retcode=1)
+ )
+
yield (
api.test('compile_failure_without_patch_ng') +
api.platform('linux', 64) +

Powered by Google App Engine
This is Rietveld 408576698