Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: scripts/slave/recipe_modules/chromium/test_api.py

Issue 1819613002: Flip remaining chromium_gn bots to the chromium recipe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: update w/ review feedback, add deapply test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium/test_api.py
diff --git a/scripts/slave/recipe_modules/chromium/test_api.py b/scripts/slave/recipe_modules/chromium/test_api.py
index 84ce0eff8a04cc5c9197714e02a5fd8f8ce219f0..2b1834e0a75786f1e086b16e1686c924d935a907 100644
--- a/scripts/slave/recipe_modules/chromium/test_api.py
+++ b/scripts/slave/recipe_modules/chromium/test_api.py
@@ -6,14 +6,13 @@ from recipe_engine import recipe_test_api
class ChromiumTestApi(recipe_test_api.RecipeTestApi):
- def gen_tests_for_builders(self, builder_dict, overrides=None):
+ def gen_tests_for_builders(self, builder_dict):
# TODO: crbug.com/354674. Figure out where to put "simulation"
# tests. Is this really the right place?
def _sanitize_nonalpha(text):
return ''.join(c if c.isalnum() else '_' for c in text)
- overrides = overrides or {}
for mastername in builder_dict:
for buildername in builder_dict[mastername]['builders']:
if 'mac' in buildername or 'Mac' in buildername:
@@ -34,10 +33,6 @@ class ChromiumTestApi(recipe_test_api.RecipeTestApi):
test += self.m.properties.generic(buildername=buildername,
mastername=mastername)
- override_step_data = overrides.get(mastername, {}).get(buildername,
- None)
- if override_step_data:
- test += override_step_data
yield test
# The following data was generated by running 'gyp_chromium

Powered by Google App Engine
This is Rietveld 408576698