scripts/slave/recipe_modules/chromium/test_api.py - Issue 1819613002: Flip remaining chromium_gn bots to the chromium recipe.

Unified Diff: scripts/slave/recipe_modules/chromium/test_api.py

Issue 1819613002: Flip remaining chromium_gn bots to the chromium recipe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium/test_api.py

diff --git a/scripts/slave/recipe_modules/chromium/test_api.py b/scripts/slave/recipe_modules/chromium/test_api.py

index 84ce0eff8a04cc5c9197714e02a5fd8f8ce219f0..cde8295c3153e0c6982cb017f635288629ac5551 100644

--- a/scripts/slave/recipe_modules/chromium/test_api.py

+++ b/scripts/slave/recipe_modules/chromium/test_api.py

@@ -36,8 +36,10 @@ class ChromiumTestApi(recipe_test_api.RecipeTestApi):

override_step_data = overrides.get(mastername, {}).get(buildername,

None)

- if override_step_data:

- test += override_step_data

+ if override_step_data: # pragma: nocover

Dirk Pranke 2016/03/19 00:34:19 The coverage bot also complained that this was now

Paweł Hajdan Jr. 2016/03/19 00:56:28 I'd suggest we remove the "overrides" parameter an

Dirk Pranke 2016/03/19 01:00:54 oh, I see, that was a separate passed in parameter

Michael Achenbach 2016/03/21 09:19:35 Remove is fine.

+ # No tests currently use this, but it would be really

+ # confusing if 'override_step_data' wasn't supported.

+ test += override_step_data

yield test

# The following data was generated by running 'gyp_chromium