Flip remaining chromium_gn bots to the chromium recipe.

scripts/slave/recipe_modules/chromium/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 from recipe_engine import recipe_api
 from recipe_engine import util as recipe_util
 
 class TestLauncherFilterFileInputPlaceholder(recipe_util.Placeholder):
@@ skipping 120 matching lines @@
       self.apply_config(c)
 
     # Note that we have to call gclient.set_config() and apply_config() *after*
     # calling chromium.set_config(), above, because otherwise the chromium
     # call would reset the gclient config to its defaults.
     self.m.gclient.set_config(
         'chromium', PATCH_PROJECT=self.m.properties.get('patch_project'))
     for c in bot_config.get('gclient_apply_config', []):
       self.m.gclient.apply_config(c)
 
-    if bot_config.get('set_component_rev'):

[Dirk Pranke, 2016/03/19 00:34:19]

The coverage report complained that this was uncovered once I removed the
recipe.

I can see where this was getting set in the chromium_gn recipe, but it looks
like it was only used
by the v8 bots there. 

The same feature exists in the client_v8_fyi.py bot configs in chromium_tests,
but I can't tell if it is simply being ignored, or if maybe it's being handled
elsewhere.

I'm not actually sure what this was for.

@machenbach, any thoughts?

[Paweł Hajdan Jr., 2016/03/19 00:56:28]

Ah, configure_bot is not used by the chromium recipe. However, I think it'd be
more correct to move this logic somewhere in chromium_tests rather than delete
it completely.

[Dirk Pranke, 2016/03/19 01:00:54]

I don't think I follow you here. Are you suggesting that we should move this
into chromium_tests
because without it the v8 bots won't work right, or are you suggesting we should
move it just
in case we might need it in the future?

[Paweł Hajdan Jr., 2016/03/19 01:08:32]

My rationale is because of v8 bots.

[Michael Achenbach, 2016/03/21 09:19:35]

I'm ok with deleting this code. A similar piece of code exists in 1-2 more
places and looking at the expectations I can see that it is exercised.

-      # If this is a component build and the main revision is e.g. blink,
-      # webrtc, or v8, the custom deps revision of this component must be
-      # dynamically set to either:
-      # (1) 'revision' from the waterfall, or
-      # (2) 'HEAD' for forced builds with unspecified 'revision'.
-      # TODO(machenbach): If this method is used on testers it also needs case
-      # (3) parent_got_revision.
-      component_rev = self.m.properties.get('revision') or 'HEAD'
-      dep = bot_config.get('set_component_rev')
-      self.m.gclient.c.revisions[dep['name']] = dep['rev_str'] % component_rev
-
     return (buildername, bot_config)
 
   def compile(self, targets=None, name=None, force_clobber=False, out_dir=None,
               target=None, **kwargs):
     """Return a compile.py invocation."""
     targets = targets or self.c.compile_py.default_targets.as_jsonish()
     assert isinstance(targets, (list, tuple))
 
     if self.c.gyp_env.GYP_DEFINES.get('clang', 0) == 1:
       # Get the Clang revision before compiling.
@@ skipping 552 matching lines @@
       }))
 
   def get_annotate_by_test_name(self, test_name):
     return 'graphing'
 
   def download_lto_plugin(self):
     return self.m.python(
         name='download LTO plugin',
         script=self.m.path['checkout'].join(
             'build', 'download_gold_plugin.py'))