third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp - Issue 1819603003: Shift flowthread-to-visual coordinate space conversion one level up in the tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp

Issue 1819603003: Shift flowthread-to-visual coordinate space conversion one level up in the tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update unit tests. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/layout/api/LayoutItem.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp b/third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp

index 924d619149ceeb3e930952e250847aa8aa9aa54c..ff0a4d973f021339cf034e73bd12e996adc0c760 100644

--- a/third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp

+++ b/third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp

@@ -490,7 +490,7 @@ TEST_F(MapCoordinatesTest, MulticolWithText)

LayoutBox* multicol = toLayoutBox(getLayoutObjectByElementId("multicol"));

FloatPoint mappedPoint = mapLocalToAncestor(target, flowThread, FloatPoint(10, 70));

- EXPECT_EQ(FloatPoint(220, 20), mappedPoint);

+ EXPECT_EQ(FloatPoint(10, 70), mappedPoint);

mappedPoint = mapLocalToAncestor(flowThread, multicol, mappedPoint);

EXPECT_EQ(FloatPoint(225, 25), mappedPoint);

@@ -515,7 +515,7 @@ TEST_F(MapCoordinatesTest, MulticolWithInline)

LayoutBox* multicol = toLayoutBox(getLayoutObjectByElementId("multicol"));

FloatPoint mappedPoint = mapLocalToAncestor(target, flowThread, FloatPoint(10, 70));

- EXPECT_EQ(FloatPoint(220, 20), mappedPoint);

+ EXPECT_EQ(FloatPoint(10, 70), mappedPoint);

mappedPoint = mapLocalToAncestor(flowThread, multicol, mappedPoint);

EXPECT_EQ(FloatPoint(225, 25), mappedPoint);

@@ -548,7 +548,7 @@ TEST_F(MapCoordinatesTest, MulticolWithBlock)

ASSERT_TRUE(flowThread->isLayoutFlowThread());

mappedPoint = mapLocalToAncestor(target, flowThread, FloatPoint());

- EXPECT_EQ(FloatPoint(110, 20), mappedPoint);

+ EXPECT_EQ(FloatPoint(10, 120), mappedPoint);

mappedPoint = mapLocalToAncestor(flowThread, container, mappedPoint);

EXPECT_EQ(FloatPoint(125, 35), mappedPoint);

@@ -587,7 +587,7 @@ TEST_F(MapCoordinatesTest, MulticolWithAbsPosInRelPos)

EXPECT_EQ(FloatPoint(25, 25), mappedPoint);

mappedPoint = mapLocalToAncestor(relpos, flowThread, mappedPoint);

- EXPECT_EQ(FloatPoint(129, 39), mappedPoint);

+ EXPECT_EQ(FloatPoint(29, 139), mappedPoint);

mappedPoint = mapLocalToAncestor(flowThread, multicol, mappedPoint);

EXPECT_EQ(FloatPoint(144, 54), mappedPoint);

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/layout/api/LayoutItem.h » ('j') | no next file with comments »