chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html - Issue 1819563002: MD Settings: Certificate manager, populate UI.

Side by Side Diff: chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html

Issue 1819563002: MD Settings: Certificate manager, populate UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.js ('K') | « chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.js ('k') | chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js » ('j') | chrome/test/data/webui/settings/certificate_manager_page_test.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://md-settings/certificate_manager_page/certifica tes_browser_proxy.html">

	3 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-drop down.html">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

	7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">

	8 <link rel="import" href="chrome://md-settings/settings_shared_css.html">

	9

	10 <dom-module id="settings-certificate-subentry">

	11 <template>

	12 <style include="settings-shared">

	13 .dropdown-content {

	14 background: white;

	15 box-shadow: 0 2px 6px grey;
	Dan Beam 2016/03/22 02:08:28 should grey be a --paper or --google var()? should grey be a --paper or --google var()? dpapad 2016/03/22 18:07:02 Yes, probably. Added TODO. I copied this value fro Show quoted text On 2016/03/22 at 02:08:28, Dan Beam wrote: > should grey be a --paper or --google var()? Yes, probably. Added TODO. I copied this value from similar menu in searchEngines, see https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res.... Prefer to do polish in separate CL though.
	16 }

	17 .container {

	18 display: flex;

	19 line-height: 30px;

	20 }

	21 .name {

	22 flex: auto;

	23 margin: auto;

	24 }

	25 paper-item:hover {

	26 background-color: #f0f0f0;
	Dan Beam 2016/03/22 02:08:28 same with this color: can it be a --paper or --goo same with this color: can it be a --paper or --google var? dpapad 2016/03/22 18:07:02 Done. Show quoted text On 2016/03/22 at 02:08:28, Dan Beam wrote: > same with this color: can it be a --paper or --google var? Done.
	27 }

	28 </style>

	29 <div class="container">

	30 <paper-icon-button icon="image:brightness-1"></paper-icon-button>

	31 <div class="name">[[model.name]]</div>

	32 <paper-icon-button icon="more-vert" toggles active="{{menuOpened}}">

	33 </paper-icon-button>

	34 <template is="dom-if" if="[[menuOpened]]">

	35 <iron-dropdown vertical-align="top" horizontal-align="right"

	36 opened="{{menuOpened}}">

	37 <div class="dropdown-content">
	Dan Beam 2016/03/22 02:08:28 indent off (should only be \s\s instead of \s\s\s\ indent off (should only be \s\s instead of \s\s\s\s) dpapad 2016/03/22 18:07:02 Done. Show quoted text On 2016/03/22 at 02:08:28, Dan Beam wrote: > indent off (should only be \s\s instead of \s\s\s\s) Done.
	38 <paper-item on-tap="onViewTap_">

	39 $i18n{certificateManagerView}

	40 </paper-item>

	41 <paper-item hidden$="[[!canEdit_(certificateType)]]"

	42 on-tap="onEditTap_">

	43 $i18n{certificateManagerEdit}

	44 </paper-item>

	45 <paper-item on-tap="onExportTap_">

	46 $i18n{certificateManagerExport}

	47 </paper-item>

	48 <paper-item hidden$="[[!canImport_(certificateType)]]"

	49 on-tap="onImportTap_">

	50 $i18n{certificateManagerImport}

	51 </paper-item>

	52 <paper-item hidden$="[[model.readonly]]"

	53 on-tap="onDeleteTap_">

	54 $i18n{certificateManagerDelete}

	55 </paper-item>

	56 <div>
	Dan Beam 2016/03/22 02:08:28 this should be </div> this should be </div> dpapad 2016/03/22 18:07:02 Done. Good catch. Show quoted text On 2016/03/22 at 02:08:28, Dan Beam wrote: > this should be </div> Done. Good catch.
	57 </iron-dropdown>

	58 </template>

	59 <div>

	60 </template>

	61 <script src="certificate_subentry.js"></script>

	62 </dom-module>

OLD	NEW