chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html - Issue 1819563002: MD Settings: Certificate manager, populate UI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html

Issue 1819563002: MD Settings: Certificate manager, populate UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/certificate_manager_page/certificate_entry.js » ('j') | chrome/browser/resources/settings/certificate_manager_page/certificate_list.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://md-settings/certificate_manager_page/certifica tes_browser_proxy.html">

	3 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-drop down.html">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml">

	7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

	8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">

	9 <link rel="import" href="chrome://md-settings/settings_shared_css.html">

	10 <link rel="import" href="chrome://md-settings/certificate_manager_page/certifica te_subentry.html">

	11

	12 <dom-module id="settings-certificate-entry">

	13 <template>

	14 <style include="settings-shared">

	15 iron-collapse {

	16 margin: 0 20px;

	17 }

	18 </style>

	19

	20 <div class="settings-box">

	21 <div class="start">[[model.id]]</div>

	22 <cr-expand-button expanded="{{expanded_}}"></cr-expand-button>

	23 </div>

	24 <iron-collapse opened="[[expanded_]]" no-animation>
	Dan Beam 2016/03/22 02:08:28 do we use no-animation everywhere? do we use no-animation everywhere? dpapad 2016/03/22 18:07:02 Not that I know of. The reason I am using it here Show quoted text On 2016/03/22 at 02:08:28, Dan Beam wrote: > do we use no-animation everywhere? Not that I know of. The reason I am using it here is for performance (and probably as a temporary solution). If I don't use no-animation here performance is degraded, because I also need to remove the dom-if below (otherwise the iron-collapse does not work). I would like to explore alternatives (iron-list or other tricks) once the page has been marked as functional.
	25 <template is="dom-if" if="[[expanded_]]">

	26 <template is="dom-repeat" items="[[model.subnodes]]">

	27 <settings-certificate-subentry model="[[item]]"

	28 certificate-type="[[certificateType]]">

	29 </settings-certificate-subentry>

	30 </template>

	31 </template>

	32 <iron-collapse>

	33 </template>

	34 <script src="certificate_entry.js"></script>

	35 </dom-module>

OLD	NEW