Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1819533002: Convert ScopedVector<DisplayPlacement> to std::vector<DisplayPlacement> (Closed)

Created:
4 years, 9 months ago by robliao
Modified:
4 years, 9 months ago
Reviewers:
Devlin, oshima, stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-options_chromium.org, sadrul, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@jsonrefactor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ScopedVector<DisplayPlacement> to std::vector<DisplayPlacement> Now that JSONValueConverter isn't used any more, we can use std::vector. BUG=595498 Committed: https://crrev.com/df372032b408542d782c18cfc057ed729e46665a Cr-Commit-Position: refs/heads/master@{#382748}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -150 lines) Patch
M ash/display/display_layout.h View 4 chunks +5 lines, -6 lines 0 comments Download
M ash/display/display_layout.cc View 7 chunks +27 lines, -28 lines 0 comments Download
M ash/display/display_layout_builder.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M ash/display/display_layout_builder_unittest.cc View 2 chunks +18 lines, -18 lines 0 comments Download
M ash/display/display_layout_store.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M ash/display/display_manager.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ash/display/extended_mouse_warp_controller.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/display/extended_mouse_warp_controller_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M ash/display/json_converter.cc View 5 chunks +13 lines, -14 lines 0 comments Download
M ash/display/json_converter_unittest.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M ash/display/mouse_cursor_event_filter_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/display/screen_position_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/window_tree_host_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 10 chunks +14 lines, -15 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1808253004 Patch 60001

Messages

Total messages: 40 (20 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819533002/1
4 years, 9 months ago (2016-03-18 21:37:20 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 22:21:22 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819533002/20001
4 years, 9 months ago (2016-03-18 22:43:00 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819533002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819533002/40001
4 years, 9 months ago (2016-03-19 00:14:36 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-19 00:54:49 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819533002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819533002/60001
4 years, 9 months ago (2016-03-21 20:19:36 UTC) #15
robliao
oshima: Here's the next in the series. Thanks!
4 years, 9 months ago (2016-03-21 20:28:21 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-21 20:58:41 UTC) #20
oshima
lgtm
4 years, 9 months ago (2016-03-21 22:18:32 UTC) #21
robliao
Please provide OWNER approval for the files under your name. Thanks! rdevlin.cronin: chrome/browser/extensions/display_info_provider_chromeos.cc stevenjb: chrome/browser/ui/webui/options/chromeos/display_options_handler.c
4 years, 9 months ago (2016-03-21 22:27:08 UTC) #23
Devlin
extensions lgtm
4 years, 9 months ago (2016-03-21 22:34:51 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819533002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819533002/60001
4 years, 9 months ago (2016-03-22 17:19:44 UTC) #26
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 17:26:43 UTC) #28
robliao
On 2016/03/22 17:26:43, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 9 months ago (2016-03-22 23:24:09 UTC) #29
stevenjb
c/b lgtm
4 years, 9 months ago (2016-03-22 23:42:39 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819533002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819533002/60001
4 years, 9 months ago (2016-03-22 23:43:13 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/110737) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 9 months ago (2016-03-22 23:50:23 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819533002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819533002/60001
4 years, 9 months ago (2016-03-23 00:22:42 UTC) #36
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 9 months ago (2016-03-23 00:42:43 UTC) #38
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 00:43:48 UTC) #40
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/df372032b408542d782c18cfc057ed729e46665a
Cr-Commit-Position: refs/heads/master@{#382748}

Powered by Google App Engine
This is Rietveld 408576698