Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1819503002: Separate SBClientDownload.SignedOrWhitelistedDownload metric into two buckets, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update histogram description Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index ba8aa2e7d974703b9e82056b9b0ae5905c399184..e1f5be59d6b1feaa3f202144139e2b2c991ebd40 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -43399,6 +43399,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="SBClientDownload.CheckWhitelistResult"
+ enum="WhitelistedDownloadType">
+ <owner>jialiul@chromium.org</owner>
+ <summary>
+ For each download supported by the SafeBrowsing download protection service,
+ records if it matches a certain whitelist (e.g. matches URL whitelist,
+ matches signature whitelist, or does not match any whitelists).
+ </summary>
+</histogram>
+
<histogram name="SBClientDownload.DmgFileHasExecutable" enum="Boolean">
<owner>rsesek@chromium.org</owner>
<summary>
@@ -43538,6 +43548,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="SBClientDownload.SignedOrWhitelistedDownload">
+ <obsolete>
+ Deprecated in Chrome 50. Replaced by
+ SBClientDownload.CheckWhitelistResult.*.
+ </obsolete>
<owner>mattm@chromium.org</owner>
<summary>
Counter which is incremented whenever an executable is downloaded which is
@@ -84173,6 +84187,12 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="1" label="Revoked ephemeral permission"/>
</enum>
+<enum name="WhitelistedDownloadType" type="int">
+ <int value="0" label="Does not match any whitelists"/>
+ <int value="1" label="URL whitelist"/>
+ <int value="2" label="Signature whitelist"/>
+</enum>
+
<enum name="WiFiApMode" type="int">
<int value="0" label="Unknown"/>
<int value="1" label="Managed"/>
« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698