tools/metrics/histograms/histograms.xml - Issue 1819503002: Separate SBClientDownload.SignedOrWhitelistedDownload metric into two buckets,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1819503002: Separate SBClientDownload.SignedOrWhitelistedDownload metric into two buckets, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add another bucket Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index ba8aa2e7d974703b9e82056b9b0ae5905c399184..597d0b9c7b9541b6916b02b871161cdfee226dbd 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -43538,6 +43538,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</histogram>

+ <obsolete>

+ Deprecated in Chrome 50. Replaced by SBClientDownload.WhitelistedDownload.*.

+ </obsolete>

<owner>mattm@chromium.org</owner>

Counter which is incremented whenever an executable is downloaded which is

@@ -43545,6 +43548,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="SBClientDownload.WhitelistedDownload"

+ enum="WhitelistedDownloadType">

+ <owner>jialiul@chromium.org</owner>

+ <summary>

+ When a download starts, record if it matches a certain whitelist (e.g. URL

+ whitelist, or signature whitelist).

mattm 2016/03/21 20:57:19 Should more precisely define what this histogram m

Jialiu Lin 2016/03/21 21:26:48 You're right. Updated accordingly. Thanks!

+ </summary>

+</histogram>

<histogram name="SBClientDownload.ZipFileHasArchiveButNoExecutable"

enum="Boolean">

<owner>mattm@chromium.org</owner>

@@ -84173,6 +84185,12 @@ To add a new entry, add it with any value and run test to compute valid value.

</enum>

+<enum name="WhitelistedDownloadType" type="int">

+ <int value="0" label="Does not match any whitelists"/>

+ <int value="1" label="URL whitelist"/>

+ <int value="2" label="Signature whitelist"/>

+</enum>

« chrome/browser/safe_browsing/download_protection_service.cc ('K') | « chrome/browser/safe_browsing/download_protection_service.cc ('k') | no next file » | no next file with comments »