tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index ba8aa2e7d974703b9e82056b9b0ae5905c399184..540281bc277b5f0818b71a18f78f5bfff38d3206 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -43538,6 +43538,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="SBClientDownload.SignedOrWhitelistedDownload">
+  <obsolete>
+    Deprecated in Chrome 50. Replaced by SBClientDownload.WhitelistedDownload.*.
+  </obsolete>
   <owner>mattm@chromium.org</owner>
   <summary>
     Counter which is incremented whenever an executable is downloaded which is
@@ -43545,6 +43548,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="SBClientDownload.WhitelistedDownload"
+    enum="WhitelistedDownloadType">
+  <owner>jialiul@chromium.org</owner>
+  <summary>
+    Record whenever a download matches a certain whitelist (e.g. URL whitelist,
+    or signature whitelist).

[Alexei Svitkine (slow), 2016/03/21 15:48:37]

Nit: Mention when this is logged. Once per download when it completes?

[Jialiu Lin, 2016/03/21 20:47:56]

Done

+  </summary>
+</histogram>
+
 <histogram name="SBClientDownload.ZipFileHasArchiveButNoExecutable"
     enum="Boolean">
   <owner>mattm@chromium.org</owner>
@@ -84173,6 +84185,11 @@ To add a new entry, add it with any value and run test to compute valid value.
   <int value="1" label="Revoked ephemeral permission"/>
 </enum>
 
+<enum name="WhitelistedDownloadType" type="int">

[Alexei Svitkine (slow), 2016/03/21 15:48:37]

Have you considered recordering "does not match whitelist" as a bucket in the
same metric? This way, you can track what percentage of downloads match these
whitelist - as opposed to just absolute count which is likely not as useful. Or
is that tracked in some other way?

[Jialiu Lin, 2016/03/21 20:47:56]

Good idea! Although I guess it is probably can be computed by adding a bunch of
metrics from different places, it is definitely much easier to simply add
another bucket to this one. 

+  <int value="0" label="URL whitelist"/>
+  <int value="1" label="Signature whitelist"/>
+</enum>
+
 <enum name="WiFiApMode" type="int">
   <int value="0" label="Unknown"/>
   <int value="1" label="Managed"/>