ui/views/style/platform_style.cc - Issue 1819443002: MacViews: draw combobox arrow backgrounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/style/platform_style.cc

Issue 1819443002: MacViews: draw combobox arrow backgrounds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use Background instead of a separate Part Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/style/platform_style.cc

diff --git a/ui/views/style/platform_style.cc b/ui/views/style/platform_style.cc

index e5e43e00a99a3e04d141339cf0c63c35813edbae..6973f4314112bbbf2f250c65534d547888b80406 100644

--- a/ui/views/style/platform_style.cc

+++ b/ui/views/style/platform_style.cc

@@ -15,6 +15,11 @@ namespace views {

#if !defined(OS_MACOSX)

// static

+scoped_ptr<Background> PlatformStyle::CreateComboboxBackground() {

tapted 2016/03/22 23:04:33 nit: move below CreateCombboxBorder

Elly Fong-Jones 2016/03/23 18:07:44 Done.

+ return make_scoped_ptr(nullptr);

sky 2016/03/22 23:54:30 nit: return nullptr;

Elly Fong-Jones 2016/03/23 18:07:44 Done.

+// static

scoped_ptr<FocusableBorder> PlatformStyle::CreateComboboxBorder() {

return make_scoped_ptr(new FocusableBorder());

}