ui/views/controls/combobox/combobox.h - Issue 1819443002: MacViews: draw combobox arrow backgrounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/combobox/combobox.h

Issue 1819443002: MacViews: draw combobox arrow backgrounds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use Background instead of a separate Part Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/combobox/combobox.h

diff --git a/ui/views/controls/combobox/combobox.h b/ui/views/controls/combobox/combobox.h

index a0f5b48b161409a2b4668a994727a2f54338ed73..9388920dcef482dc696ec1ceae63b2711f09700d 100644

--- a/ui/views/controls/combobox/combobox.h

+++ b/ui/views/controls/combobox/combobox.h

@@ -106,6 +106,8 @@ class VIEWS_EXPORT Combobox : public PrefixDelegate, public ButtonListener {

// Overriden from ButtonListener:

void ButtonPressed(Button* sender, const ui::Event& event) override;

+ int GetArrowButtonWidth() const;

tapted 2016/03/22 23:04:32 nit: move up before overrides also comment - some

Elly Fong-Jones 2016/03/23 18:07:44 Done.

private:

friend class test::ComboboxTestApi;