ui/views/style/mac/combobox_background_mac.h - Issue 1819443002: MacViews: draw combobox arrow backgrounds

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/views/style/mac/combobox_background_mac.h

Issue 1819443002: MacViews: draw combobox arrow backgrounds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use Background instead of a separate Part Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ui/views/controls/combobox/combobox.cc ('K') | « ui/views/examples/combobox_example.cc ('k') | ui/views/style/mac/combobox_background_mac.cc » ('j') | ui/views/style/mac/combobox_background_mac.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_VIEWS_STYLE_MAC_COMBOBOX_BACKGROUND_MAC_H_

	6 #define UI_VIEWS_STYLE_MAC_COMBOBOX_BACKGROUND_MAC_H_

	7

	8 #include "ui/views/background.h"

	9

	10 namespace gfx {

	11 class Canvas;

	12 } // namespace gfx
	tapted 2016/03/22 23:04:33 nit: comments don't usually get put on the namespa nit: comments don't usually get put on the namespace blocks used for forward decs Elly Fong-Jones 2016/03/23 18:07:44 Done. Show quoted text On 2016/03/22 23:04:33, tapted (OOO.travel to Apr 5th) wrote: > nit: comments don't usually get put on the namespace blocks used for forward > decs Done.
	13

	14 namespace views {

	15

	16 class ComboboxBackgroundMac : public Background {
	tapted 2016/03/22 23:04:32 needs a brief comment needs a brief comment Elly Fong-Jones 2016/03/23 18:07:44 Done. Show quoted text On 2016/03/22 23:04:32, tapted (OOO.travel to Apr 5th) wrote: > needs a brief comment Done.
	17 public:

	18 ComboboxBackgroundMac() {}
	tapted 2016/03/22 23:04:32 nit: these should be defined in the .cc [there's nit: these should be defined in the .cc [there's usually a clang chromium-style warning about cases where the destructor is non-trivial - technically the destructor is trivial, but the compiler shouldn't know that since Background's destructor is in its .cc] Elly Fong-Jones 2016/03/23 18:07:44 Done. Show quoted text On 2016/03/22 23:04:32, tapted (OOO.travel to Apr 5th) wrote: > nit: these should be defined in the .cc [there's usually a clang chromium-style > warning about cases where the destructor is non-trivial - technically the > destructor is trivial, but the compiler shouldn't know that since Background's > destructor is in its .cc] Done.
	19 ~ComboboxBackgroundMac() override {}

	20

	21 void Paint(gfx::Canvas* canvas, View* view) const override;
	tapted 2016/03/22 23:04:33 nit: // Background: nit: // Background: Elly Fong-Jones 2016/03/23 18:07:44 Done. Show quoted text On 2016/03/22 23:04:33, tapted (OOO.travel to Apr 5th) wrote: > nit: // Background: Done.
	22 };
	tapted 2016/03/22 23:04:32 nit: private: DISALLOW_COPY_AND_ASSIGN nit: private: DISALLOW_COPY_AND_ASSIGN Elly Fong-Jones 2016/03/23 18:07:44 Done. Show quoted text On 2016/03/22 23:04:32, tapted (OOO.travel to Apr 5th) wrote: > nit: private: DISALLOW_COPY_AND_ASSIGN Done.
	23

	24 } // namespace views

	25

	26 #endif // UI_VIEWS_STYLE_MAC_COMBOBOX_BACKGROUND_MAC_H_

OLD	NEW