Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1819433003: Revert of Inline fast-path interceptor access in the IC utilities (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Inline fast-path interceptor access in the IC utilities (patchset #2 id:20001 of https://codereview.chromium.org/1810083003/ ) Reason for revert: [Sheriff] Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5506 Original issue's description: > Inline fast-path interceptor access in the IC utilities > > BUG= > > Committed: https://crrev.com/b3bda50ddd9e30b718ae7972d9dd0d095113f634 > Cr-Commit-Position: refs/heads/master@{#34892} TBR=jkummerow@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/3245d74490933aeda9cf3fc79e216d79df52aa3a Cr-Commit-Position: refs/heads/master@{#34905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -53 lines) Patch
M src/ic/ic.cc View 3 chunks +19 lines, -53 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Inline fast-path interceptor access in the IC utilities
4 years, 9 months ago (2016-03-18 18:16:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819433003/1
4 years, 9 months ago (2016-03-18 18:16:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 18:16:49 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 18:17:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3245d74490933aeda9cf3fc79e216d79df52aa3a
Cr-Commit-Position: refs/heads/master@{#34905}

Powered by Google App Engine
This is Rietveld 408576698