Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1819413002: Don't DCHECK in EventDispatcher::RemoveAccelerator (Closed)

Created:
4 years, 9 months ago by sky
Modified:
4 years, 9 months ago
Reviewers:
jonross
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't DCHECK in EventDispatcher::RemoveAccelerator Clients may supply any bogus ids, so we shouldn't DCHECK here. BUG=none TEST=none R=jonross@chromium.org Committed: https://crrev.com/7db3e75aa85f80a24e1ab397ec7c5fdb5bf21645 Cr-Commit-Position: refs/heads/master@{#382634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M components/mus/ws/event_dispatcher.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 9 months ago (2016-03-22 17:37:48 UTC) #1
jonross
On 2016/03/22 17:37:48, sky wrote: LGTM
4 years, 9 months ago (2016-03-22 18:01:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819413002/1
4 years, 9 months ago (2016-03-22 18:10:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 19:23:52 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 19:26:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7db3e75aa85f80a24e1ab397ec7c5fdb5bf21645
Cr-Commit-Position: refs/heads/master@{#382634}

Powered by Google App Engine
This is Rietveld 408576698