src/optimizing-compiler-thread.cc - Issue 18194004: Avoid data race in debug mode on the parallel thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/optimizing-compiler-thread.cc

Issue 18194004: Avoid data race in debug mode on the parallel thread. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/optimizing-compiler-thread.cc

diff --git a/src/optimizing-compiler-thread.cc b/src/optimizing-compiler-thread.cc

index b9ff7d83eca369c0b194ab2cd40ccdec5c9379be..a38a0db9b08bc96ecca9fc6d0a3272e6e6a8648e 100644

--- a/src/optimizing-compiler-thread.cc

+++ b/src/optimizing-compiler-thread.cc

@@ -39,7 +39,9 @@ namespace internal {

void OptimizingCompilerThread::Run() {

#ifdef DEBUG

- thread_id_ = ThreadId::Current().ToInteger();

+ { ScopedLock lock(thread_id_mutex_);

+ thread_id_ = ThreadId::Current().ToInteger();

+ }

#endif

Isolate::SetIsolateThreadLocals(isolate_, NULL);

DisallowHeapAllocation no_allocation;

@@ -156,7 +158,8 @@ void OptimizingCompilerThread::QueueForOptimization(

#ifdef DEBUG

bool OptimizingCompilerThread::IsOptimizerThread() {

if (!FLAG_parallel_recompilation) return false;

- return ThreadId::Current().ToInteger() == thread_id_;

+ ScopedLock lock(thread_id_mutex_);

+ return ThreadId::Current().ToInteger() == thread_id_;

Jakob Kummerow 2013/06/28 11:00:54 nit: duplicate space after 'return'

}

#endif

« no previous file with comments | « src/optimizing-compiler-thread.h ('k') | no next file » | no next file with comments »