Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: src/optimizing-compiler-thread.h

Issue 18194004: Avoid data race in debug mode on the parallel thread. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: git cl dcommit Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/optimizing-compiler-thread.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 28 matching lines...) Expand all
39 class HOptimizedGraphBuilder; 39 class HOptimizedGraphBuilder;
40 class OptimizingCompiler; 40 class OptimizingCompiler;
41 class SharedFunctionInfo; 41 class SharedFunctionInfo;
42 42
43 class OptimizingCompilerThread : public Thread { 43 class OptimizingCompilerThread : public Thread {
44 public: 44 public:
45 explicit OptimizingCompilerThread(Isolate *isolate) : 45 explicit OptimizingCompilerThread(Isolate *isolate) :
46 Thread("OptimizingCompilerThread"), 46 Thread("OptimizingCompilerThread"),
47 #ifdef DEBUG 47 #ifdef DEBUG
48 thread_id_(0), 48 thread_id_(0),
49 thread_id_mutex_(OS::CreateMutex()),
49 #endif 50 #endif
50 isolate_(isolate), 51 isolate_(isolate),
51 stop_semaphore_(OS::CreateSemaphore(0)), 52 stop_semaphore_(OS::CreateSemaphore(0)),
52 input_queue_semaphore_(OS::CreateSemaphore(0)), 53 input_queue_semaphore_(OS::CreateSemaphore(0)),
53 install_mutex_(OS::CreateMutex()), 54 install_mutex_(OS::CreateMutex()),
54 time_spent_compiling_(0), 55 time_spent_compiling_(0),
55 time_spent_total_(0) { 56 time_spent_total_(0) {
56 NoBarrier_Store(&stop_thread_, static_cast<AtomicWord>(false)); 57 NoBarrier_Store(&stop_thread_, static_cast<AtomicWord>(false));
57 NoBarrier_Store(&queue_length_, static_cast<AtomicWord>(0)); 58 NoBarrier_Store(&queue_length_, static_cast<AtomicWord>(0));
58 } 59 }
(...skipping 23 matching lines...) Expand all
82 #endif 83 #endif
83 84
84 ~OptimizingCompilerThread() { 85 ~OptimizingCompilerThread() {
85 delete input_queue_semaphore_; 86 delete input_queue_semaphore_;
86 delete stop_semaphore_; 87 delete stop_semaphore_;
87 } 88 }
88 89
89 private: 90 private:
90 #ifdef DEBUG 91 #ifdef DEBUG
91 int thread_id_; 92 int thread_id_;
93 Mutex* thread_id_mutex_;
92 #endif 94 #endif
93 95
94 Isolate* isolate_; 96 Isolate* isolate_;
95 Semaphore* stop_semaphore_; 97 Semaphore* stop_semaphore_;
96 Semaphore* input_queue_semaphore_; 98 Semaphore* input_queue_semaphore_;
97 UnboundQueue<OptimizingCompiler*> input_queue_; 99 UnboundQueue<OptimizingCompiler*> input_queue_;
98 UnboundQueue<OptimizingCompiler*> output_queue_; 100 UnboundQueue<OptimizingCompiler*> output_queue_;
99 Mutex* install_mutex_; 101 Mutex* install_mutex_;
100 volatile AtomicWord stop_thread_; 102 volatile AtomicWord stop_thread_;
101 volatile Atomic32 queue_length_; 103 volatile Atomic32 queue_length_;
102 int64_t time_spent_compiling_; 104 int64_t time_spent_compiling_;
103 int64_t time_spent_total_; 105 int64_t time_spent_total_;
104 }; 106 };
105 107
106 } } // namespace v8::internal 108 } } // namespace v8::internal
107 109
108 #endif // V8_OPTIMIZING_COMPILER_THREAD_H_ 110 #endif // V8_OPTIMIZING_COMPILER_THREAD_H_
OLDNEW
« no previous file with comments | « no previous file | src/optimizing-compiler-thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698