Issue 18194004: Avoid data race in debug mode on the parallel thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18194004: Avoid data race in debug mode on the parallel thread. (Closed)

Created:
7 years, 5 months ago by Yang

Modified:
7 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Avoid data race in debug mode on the parallel thread. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15376

Patch Set 2 : git cl dcommit #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/optimizing-compiler-thread.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	src/optimizing-compiler-thread.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM, thanks! https://codereview.chromium.org/18194004/diff/1/src/optimizing-compiler-thread.cc File src/optimizing-compiler-thread.cc (right): https://codereview.chromium.org/18194004/diff/1/src/optimizing-compiler-thread.cc#newcode162 src/optimizing-compiler-thread.cc:162: return ThreadId::Current().ToInteger() == thread_id_; nit: duplicate space ...

7 years, 5 months ago (2013-06-28 11:00:54 UTC) #2

Yang

On 2013/06/28 11:00:54, Jakob wrote: > LGTM, thanks! > > https://codereview.chromium.org/18194004/diff/1/src/optimizing-compiler-thread.cc > File src/optimizing-compiler-thread.cc (right): ...

7 years, 5 months ago (2013-06-28 11:24:20 UTC) #3

Yang

7 years, 5 months ago (2013-06-28 11:24:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r15376 (presubmit successful).

Expand Messages | Collapse Messages

Issue 18194004: Avoid data race in debug mode on the parallel thread. (Closed)

Description

Patch Set 1 #

Patch Set 2 : git cl dcommit #

Messages