Switch SkMorphologyImageFilter over to new onFilterImage interface

Switch SkMorphologyImageFilter over to new onFilterImage interface

This now relies on: https://codereview.chromium.org/1826233002/ (Add rowBytesAsPixels and shiftPerPixel to SkPixmap)

TBR=bsalomon@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1819393002

Committed: https://skia.googlesource.com/skia/+/f299e7105435829c47e94f4cf6e408cad675bc77

[robertphillips, 2016-03-22 17:13:26]

Description was changed from

==========
Switch SkMorphologyImageFilter over to new onFilterImage interface
==========

to

==========
Switch SkMorphologyImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-24 14:40:59]

Description was changed from

==========
Switch SkMorphologyImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkMorphologyImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-24 14:40:59]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com, senorblanco@chromium.org, senorblanco@google.com

[robertphillips, 2016-03-24 14:41:05]

Description was changed from

==========
Switch SkMorphologyImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkMorphologyImageFilter over to new onFilterImage interface

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-03-24 14:57:03]

LGTM if the bots like it

https://codereview.chromium.org/1819393002/diff/100001/src/effects/SkMorpholo...
File src/effects/SkMorphologyImageFilter.cpp (right):

https://codereview.chromium.org/1819393002/diff/100001/src/effects/SkMorpholo...
src/effects/SkMorphologyImageFilter.cpp:624: SkIRect::MakeWH(bounds.width(),
bounds.height()),
Not new to this patch, but could we make the subset param to ::MakeFromRaster()
optional? It seems like most of the filters are going to pass dst.bounds() here.

https://codereview.chromium.org/1819393002/diff/100001/src/effects/SkMorpholo...
src/effects/SkMorphologyImageFilter.cpp:630: return
this->filterImageGeneric(true, source, ctx, offset);
Not new to this patch, but we should probably replace this bool with an enum, so
these callsites are clearer.

[Stephen White, 2016-03-24 15:16:35]

https://codereview.chromium.org/1819393002/diff/100001/src/effects/SkMorpholo...
File src/effects/SkMorphologyImageFilter.cpp (right):

https://codereview.chromium.org/1819393002/diff/100001/src/effects/SkMorpholo...
src/effects/SkMorphologyImageFilter.cpp:614: int shiftPerPixel =
SkColorTypeBytesPerPixel(inputPixmap.colorType()) >> 1;
As a side note, could we have SkPixmap::getRowBytesAsPixels()? Then we wouldn't
have to sprinkle these obscure shifts all over the code.

[robertphillips, 2016-03-24 18:06:45]

Description was changed from

==========
Switch SkMorphologyImageFilter over to new onFilterImage interface

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkMorphologyImageFilter over to new onFilterImage interface

This now relies on: https://codereview.chromium.org/1826233002/ (Add
rowBytesAsPixels and shiftPerPixel to SkPixmap)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-24 18:08:13]

https://codereview.chromium.org/1819393002/diff/100001/src/effects/SkMorpholo...
File src/effects/SkMorphologyImageFilter.cpp (right):

https://codereview.chromium.org/1819393002/diff/100001/src/effects/SkMorpholo...
src/effects/SkMorphologyImageFilter.cpp:614: int shiftPerPixel =
SkColorTypeBytesPerPixel(inputPixmap.colorType()) >> 1;
On 2016/03/24 15:16:34, Stephen White wrote:
> As a side note, could we have SkPixmap::getRowBytesAsPixels()? Then we
wouldn't
> have to sprinkle these obscure shifts all over the code.

Done.

https://codereview.chromium.org/1819393002/diff/100001/src/effects/SkMorpholo...
src/effects/SkMorphologyImageFilter.cpp:624: SkIRect::MakeWH(bounds.width(),
bounds.height()),
On 2016/03/24 14:57:02, Stephen White wrote:
> Not new to this patch, but could we make the subset param to
::MakeFromRaster()
> optional? It seems like most of the filters are going to pass dst.bounds()
here.

Acknowledged.

https://codereview.chromium.org/1819393002/diff/100001/src/effects/SkMorpholo...
src/effects/SkMorphologyImageFilter.cpp:630: return
this->filterImageGeneric(true, source, ctx, offset);
On 2016/03/24 14:57:03, Stephen White wrote:
> Not new to this patch, but we should probably replace this bool with an enum,
so
> these callsites are clearer.

Let me do that in a follow up CL. I think this CL is exciting enough as is.

[Stephen White, 2016-03-24 18:30:43]

Great; LGTM even moar :)

[Stephen White, 2016-03-24 18:30:45]

Great; LGTM even moar :)

[robertphillips, 2016-03-24 18:33:04]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 18:33:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819393002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819393002/120001

[commit-bot: I haz the power, 2016-03-24 18:52:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 18:52:04]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-03-25 11:45:28]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-03-25 11:45:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819393002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819393002/120001

[commit-bot: I haz the power, 2016-03-25 11:47:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 11:47:08]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[robertphillips, 2016-03-25 11:48:12]

Description was changed from

==========
Switch SkMorphologyImageFilter over to new onFilterImage interface

This now relies on: https://codereview.chromium.org/1826233002/ (Add
rowBytesAsPixels and shiftPerPixel to SkPixmap)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkMorphologyImageFilter over to new onFilterImage interface

This now relies on: https://codereview.chromium.org/1826233002/ (Add
rowBytesAsPixels and shiftPerPixel to SkPixmap)

TBR=bsalomon@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-25 11:48:18]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-03-25 11:48:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819393002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819393002/120001

[commit-bot: I haz the power, 2016-03-25 11:49:27]

Description was changed from

==========
Switch SkMorphologyImageFilter over to new onFilterImage interface

This now relies on: https://codereview.chromium.org/1826233002/ (Add
rowBytesAsPixels and shiftPerPixel to SkPixmap)

TBR=bsalomon@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkMorphologyImageFilter over to new onFilterImage interface

This now relies on: https://codereview.chromium.org/1826233002/ (Add
rowBytesAsPixels and shiftPerPixel to SkPixmap)

TBR=bsalomon@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/f299e7105435829c47e94f4cf6e408cad675bc77
==========

[commit-bot: I haz the power, 2016-03-25 11:49:28]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/f299e7105435829c47e94f4cf6e408cad675bc77