Pepper: Simplify FileDownloader::url().

Pepper: Simplify FileDownloader::url().

The current behavior of FileDownloader::url() is strange since the value
changes after the initial GET request. I've found this a little awkward, and
decided to make url() always return the url passed to FileDownloader, and
full_url() return the extra url information from the GET request.

BUG=
R=dmichael@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255156

[dmichael (off chromium), 2014-03-05 16:11:35]

This seems clearer to me, thanks. lgtm

https://codereview.chromium.org/181933005/diff/1/ppapi/native_client/src/trus...
File ppapi/native_client/src/trusted/plugin/file_downloader.h (right):

https://codereview.chromium.org/181933005/diff/1/ppapi/native_client/src/trus...
ppapi/native_client/src/trusted/plugin/file_downloader.h:150: // scheme, host
and full path.
This comment needs to be updated with the new method. And maybe note what it
returns before the full URL is available (empty string?)

[teravest, 2014-03-05 16:26:00]

The CQ bit was checked by teravest@chromium.org

[teravest, 2014-03-05 16:26:06]

On Wed, Mar 5, 2014 at 9:11 AM,  <dmichael@chromium.org> wrote:
> This seems clearer to me, thanks. lgtm
>
>
>
https://codereview.chromium.org/181933005/diff/1/ppapi/native_client/src/trus...
> File ppapi/native_client/src/trusted/plugin/file_downloader.h (right):
>
>
https://codereview.chromium.org/181933005/diff/1/ppapi/native_client/src/trus...
> ppapi/native_client/src/trusted/plugin/file_downloader.h:150: // scheme,
> host and full path.
> This comment needs to be updated with the new method. And maybe note
> what it returns before the full URL is available (empty string?)

Done.

>
> https://codereview.chromium.org/181933005/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-03-05 16:26:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/181933005/20001

[commit-bot: I haz the power, 2014-03-05 17:51:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 17:51:33]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[teravest, 2014-03-05 20:01:56]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-03-05 20:02:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/181933005/20001

[commit-bot: I haz the power, 2014-03-05 21:35:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 21:35:23]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[teravest, 2014-03-05 21:50:47]

Committed patchset #5 manually as r255156 (presubmit successful).