[regexp, intl] Intl should not cause side effects to the RegExp object.

[regexp, intl] Intl should not cause side effects to the RegExp object.

R=jochen@chromium.org
BUG=v8:4361
LOG=N

Committed: https://crrev.com/4c1d670e9817cd4f33eadc613108f54f82db91c5
Cr-Commit-Position: refs/heads/master@{#35099}

[Yang, 2016-03-22 10:00:15]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 10:00:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819313002/20001

[commit-bot: I haz the power, 2016-03-22 10:12:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 10:12:56]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/17440)

[Yang, 2016-03-22 14:18:11]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 14:18:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819313002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819313002/40001

[commit-bot: I haz the power, 2016-03-22 14:39:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 14:39:12]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-03-23 14:22:48]

On 2016/03/22 14:39:12, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

ping

[Yang, 2016-03-23 14:26:50]

yangguo@chromium.org changed reviewers:
+ littledan@chromium.org
- jochen@chromium.org

[Yang, 2016-03-23 14:26:51]

Dan, could you take a look at this? Thanks.

[Dan Ehrenberg, 2016-03-23 15:55:41]

Very glad to have this fix; a couple minor comments.

https://codereview.chromium.org/1819313002/diff/40001/src/js/i18n.js
File src/js/i18n.js (right):

https://codereview.chromium.org/1819313002/diff/40001/src/js/i18n.js#newcode62
src/js/i18n.js:62: RegExpReplace = from.InternalRegExpReplace;
Could you use the original names, so it's clearer when reading the code below
that uses them?

https://codereview.chromium.org/1819313002/diff/40001/src/js/regexp.js
File src/js/regexp.js (left):

https://codereview.chromium.org/1819313002/diff/40001/src/js/regexp.js#oldcod...
src/js/regexp.js:125: return %_RegExpExec(regexp, string, index,
RegExpLastMatchInfo);
Why this change? Will it have performance implications?

[Dan Ehrenberg, 2016-03-23 15:55:42]

lgtm

Very glad to have this fix; a couple minor comments.

[Dan Ehrenberg, 2016-03-23 15:55:43]

Very glad to have this fix; a couple minor comments.

[Yang, 2016-03-24 06:14:00]

addressed comments

[Yang, 2016-03-24 06:14:13]

https://codereview.chromium.org/1819313002/diff/40001/src/js/i18n.js
File src/js/i18n.js (right):

https://codereview.chromium.org/1819313002/diff/40001/src/js/i18n.js#newcode62
src/js/i18n.js:62: RegExpReplace = from.InternalRegExpReplace;
On 2016/03/23 15:55:41, Dan Ehrenberg wrote:
> Could you use the original names, so it's clearer when reading the code below
> that uses them?

Done.

https://codereview.chromium.org/1819313002/diff/40001/src/js/regexp.js
File src/js/regexp.js (left):

https://codereview.chromium.org/1819313002/diff/40001/src/js/regexp.js#oldcod...
src/js/regexp.js:125: return %_RegExpExec(regexp, string, index,
RegExpLastMatchInfo);
On 2016/03/23 15:55:41, Dan Ehrenberg wrote:
> Why this change? Will it have performance implications?

Thanks for catching this. I changed it for easier debugging, but then forgot to
revert.

[Yang, 2016-03-24 06:14:18]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 06:14:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819313002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819313002/60001

[commit-bot: I haz the power, 2016-03-24 06:37:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 06:37:11]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-03-24 07:10:39]

lgtm

Looks great. Optional additional testing idea: Actually exec a RegExp that
updates those properties, then observe that using Intl leaves those properly in
place.

[Yang, 2016-03-29 11:34:21]

On 2016/03/24 07:10:39, Dan Ehrenberg wrote:
> lgtm
> 
> Looks great. Optional additional testing idea: Actually exec a RegExp that
> updates those properties, then observe that using Intl leaves those properly
in
> place.

Implemented the suggested test.

[Yang, 2016-03-29 11:34:26]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-03-29 11:34:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/1819313002/#ps80001
(title: "addressed comment")

[commit-bot: I haz the power, 2016-03-29 11:34:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819313002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819313002/80001

[commit-bot: I haz the power, 2016-03-29 11:55:39]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-29 11:57:11]

Description was changed from

==========
[regexp, intl] Intl should not cause side effects to the RegExp object.

R=jochen@chromium.org
BUG=v8:4361
LOG=N
==========

to

==========
[regexp, intl] Intl should not cause side effects to the RegExp object.

R=jochen@chromium.org
BUG=v8:4361
LOG=N

Committed: https://crrev.com/4c1d670e9817cd4f33eadc613108f54f82db91c5
Cr-Commit-Position: refs/heads/master@{#35099}
==========

[commit-bot: I haz the power, 2016-03-29 11:57:12]

Patchset 5 (id:??) landed as
https://crrev.com/4c1d670e9817cd4f33eadc613108f54f82db91c5
Cr-Commit-Position: refs/heads/master@{#35099}