Suppress exception on unregistering device sensor.

Suppress exception on unregistering device sensor.

Digma tablets iDxD7/iDxD10 tend to throw exceptions
on sensor unregistering. I believe this is a firmware
issue. Suppress this error since it's ok to move on,
if the sensor is already unregistered.

Similar crash in mozilla tracker:
https://goo.gl/iD8sRb
Note the device list out there, it also mentions
iDxD* devices, along with some others.

R=mvanouwerkerk@chromium.org,timvolodine@chromium.org
BUG=596453
Committed: https://crrev.com/a82bdf8c0f978ea78873ccebf45ea64c3e0a7d94
Cr-Commit-Position: refs/heads/master@{#382810}

[Igor Eremeev, 2016-03-22 07:18:35]

Description was changed from

==========
Suppress exception on unregistering device sensor.

Digma tablets iDxD7/iDxD10 tend to throw exceptions on sensor
unregistering. I believe this is a firmware issue. Suppress this error
since it's ok to move on, if the sensor is already unregistered.

R=mvanouwerkerk@chromium.org,timvolodine@chromium.org
BUG=596453
==========

to

==========
Suppress exception on unregistering device sensor.

Digma tablets iDxD7/iDxD10 tend to throw exceptions on sensor unregistering. I
believe this is a firmware issue. Suppress this error since it's ok to move on,
if the sensor is already unregistered.

Similar crash in mozilla tracker:
https://crash-stats.mozilla.com/report/list?signature=java.lang.IllegalArgume...
Note the device list out there, it also mentions iDxD10 device, along with some
others.

R=mvanouwerkerk@chromium.org,timvolodine@chromium.org
BUG=596453
==========

[Igor Eremeev, 2016-03-22 07:31:56]

Hello! I've made a fix for 596453 issue. Can you please take a look?

[timvolodine, 2016-03-22 16:30:03]

Thanks for the quick fix Igor, although I am still unsure why this happens.

Could you please format the description to a more limited number of columns,
otherwise it may not be very readable.

lgtm with comments addressed

https://codereview.chromium.org/1819293002/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java
(right):

https://codereview.chromium.org/1819293002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java:695:
// Suppress occasional exception:
hmm strange, normally speaking this should never happen as we only unregister
previously successfully registered sensors.

in any case, could you please add a more detailed explanation with a reference
to crbug:
e.g. "Suppress occasional exception on Digma iDxD* devices, see
crbug.com/596453."

[Igor Eremeev, 2016-03-23 07:11:53]

Description was changed from

==========
Suppress exception on unregistering device sensor.

Digma tablets iDxD7/iDxD10 tend to throw exceptions on sensor unregistering. I
believe this is a firmware issue. Suppress this error since it's ok to move on,
if the sensor is already unregistered.

Similar crash in mozilla tracker:
https://crash-stats.mozilla.com/report/list?signature=java.lang.IllegalArgume...
Note the device list out there, it also mentions iDxD10 device, along with some
others.

R=mvanouwerkerk@chromium.org,timvolodine@chromium.org
BUG=596453
==========

to

==========
Suppress exception on unregistering device sensor.

Digma tablets iDxD7/iDxD10 tend to throw exceptions
on sensor unregistering. I believe this is a firmware
issue. Suppress this error since it's ok to move on,
if the sensor is already unregistered.

Similar crash in mozilla tracker:
https://goo.gl/iD8sRb
Note the device list out there, it also mentions
iDxD* devices, along with some others.

R=mvanouwerkerk@chromium.org,timvolodine@chromium.org
BUG=596453
==========

[Igor Eremeev, 2016-03-23 07:38:15]

On 2016/03/22 16:30:03, timvolodine wrote:
> Thanks for the quick fix Igor, although I am still unsure why this happens.
> 
> Could you please format the description to a more limited number of columns,
> otherwise it may not be very readable.
> 
> lgtm with comments addressed
> 
>
https://codereview.chromium.org/1819293002/diff/1/content/public/android/java...
> File
>
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java
> (right):
> 
>
https://codereview.chromium.org/1819293002/diff/1/content/public/android/java...
>
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java:695:
> // Suppress occasional exception:
> hmm strange, normally speaking this should never happen as we only unregister
> previously successfully registered sensors.
> 
> in any case, could you please add a more detailed explanation with a reference
> to crbug:
> e.g. "Suppress occasional exception on Digma iDxD* devices, see
> crbug.com/596453."

Yes, the code seems to be robust, I've tested all possible cases I could think
of,
like closing/switching tab in all possible ways and emulating failed
registering.
But it was on a normal device and it worked correctly, I wasn't able to
reproduce it.
So I believe this is a firmware issue.

[Igor Eremeev, 2016-03-23 07:39:40]

The CQ bit was checked by myrth@yandex-team.ru

[Igor Eremeev, 2016-03-23 07:39:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
timvolodine@chromium.org
Link to the patchset: https://codereview.chromium.org/1819293002/#ps20001
(title: "fix review issues")

[commit-bot: I haz the power, 2016-03-23 07:39:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819293002/20001

[commit-bot: I haz the power, 2016-03-23 08:47:38]

Description was changed from

==========
Suppress exception on unregistering device sensor.

Digma tablets iDxD7/iDxD10 tend to throw exceptions
on sensor unregistering. I believe this is a firmware
issue. Suppress this error since it's ok to move on,
if the sensor is already unregistered.

Similar crash in mozilla tracker:
https://goo.gl/iD8sRb
Note the device list out there, it also mentions
iDxD* devices, along with some others.

R=mvanouwerkerk@chromium.org,timvolodine@chromium.org
BUG=596453
==========

to

==========
Suppress exception on unregistering device sensor.

Digma tablets iDxD7/iDxD10 tend to throw exceptions
on sensor unregistering. I believe this is a firmware
issue. Suppress this error since it's ok to move on,
if the sensor is already unregistered.

Similar crash in mozilla tracker:
https://goo.gl/iD8sRb
Note the device list out there, it also mentions
iDxD* devices, along with some others.

R=mvanouwerkerk@chromium.org,timvolodine@chromium.org
BUG=596453
==========

[commit-bot: I haz the power, 2016-03-23 08:47:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-23 08:49:04]

Description was changed from

==========
Suppress exception on unregistering device sensor.

Digma tablets iDxD7/iDxD10 tend to throw exceptions
on sensor unregistering. I believe this is a firmware
issue. Suppress this error since it's ok to move on,
if the sensor is already unregistered.

Similar crash in mozilla tracker:
https://goo.gl/iD8sRb
Note the device list out there, it also mentions
iDxD* devices, along with some others.

R=mvanouwerkerk@chromium.org,timvolodine@chromium.org
BUG=596453
==========

to

==========
Suppress exception on unregistering device sensor.

Digma tablets iDxD7/iDxD10 tend to throw exceptions
on sensor unregistering. I believe this is a firmware
issue. Suppress this error since it's ok to move on,
if the sensor is already unregistered.

Similar crash in mozilla tracker:
https://goo.gl/iD8sRb
Note the device list out there, it also mentions
iDxD* devices, along with some others.

R=mvanouwerkerk@chromium.org,timvolodine@chromium.org
BUG=596453

Committed: https://crrev.com/a82bdf8c0f978ea78873ccebf45ea64c3e0a7d94
Cr-Commit-Position: refs/heads/master@{#382810}
==========

[commit-bot: I haz the power, 2016-03-23 08:49:05]

Patchset 2 (id:??) landed as
https://crrev.com/a82bdf8c0f978ea78873ccebf45ea64c3e0a7d94
Cr-Commit-Position: refs/heads/master@{#382810}