Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 1819273003: X87: [crankshaft] Fixing ES6 tail call elimination. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [crankshaft] Fixing ES6 tail call elimination. port acbb968dedd2b02b5447215a579cf4cdc99bc69a (r34920) original commit message: In case when F inlined normal call to G which tail calls H we should not write translation for G for the tail call site. Otherwise we will see G in a stack trace inside H. This CL also enables all existing tests related to ES6 tail call elimination and adds more combinations. BUG= Committed: https://crrev.com/9640015ec4820577077b8b8fa520817cd46445c6 Cr-Commit-Position: refs/heads/master@{#34972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -13 lines) Patch
M src/crankshaft/x87/lithium-x87.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 4 chunks +38 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-22 03:38:50 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-22 03:43:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819273003/1
4 years, 9 months ago (2016-03-22 03:47:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 04:20:48 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 04:21:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9640015ec4820577077b8b8fa520817cd46445c6
Cr-Commit-Position: refs/heads/master@{#34972}

Powered by Google App Engine
This is Rietveld 408576698