exo: Improved implementation of child surfaces and popups.

components/exo/display.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/exo/display.h"
 
 #include <iterator>
 #include <utility>
 
 #include "base/trace_event/trace_event.h"
@@ skipping 81 matching lines @@
 
 scoped_ptr<ShellSurface> Display::CreateShellSurface(Surface* surface) {
   TRACE_EVENT1("exo", "Display::CreateShellSurface", "surface",
                surface->AsTracedValue());
 
   if (surface->HasSurfaceDelegate()) {
     DLOG(ERROR) << "Surface has already been assigned a role";
     return nullptr;
   }
 
-  return make_scoped_ptr(new ShellSurface(surface, nullptr, gfx::Rect()));
+  return make_scoped_ptr(new ShellSurface(surface, nullptr, gfx::Rect(), true));
 }
 
 scoped_ptr<ShellSurface> Display::CreatePopupShellSurface(
     Surface* surface,
     ShellSurface* parent,
     const gfx::Point& position) {
   TRACE_EVENT2("exo", "Display::CreatePopupShellSurface", "surface",
                surface->AsTracedValue(), "parent", parent->AsTracedValue());
 
   if (surface->Contains(parent->GetWidget()->GetNativeWindow())) {
     DLOG(ERROR) << "Parent is contained within surface's hierarchy";
     return nullptr;
   }
 
   if (surface->HasSurfaceDelegate()) {
     DLOG(ERROR) << "Surface has already been assigned a role";
     return nullptr;
   }
 
-  return make_scoped_ptr(
-      new ShellSurface(surface, parent, gfx::Rect(position, gfx::Size(1, 1))));
+  return make_scoped_ptr(new ShellSurface(
+      surface, parent, gfx::Rect(position, gfx::Size(1, 1)), false));
 }
 
 scoped_ptr<SubSurface> Display::CreateSubSurface(Surface* surface,
                                                  Surface* parent) {
   TRACE_EVENT2("exo", "Display::CreateSubSurface", "surface",
                surface->AsTracedValue(), "parent", parent->AsTracedValue());
 
   if (surface->Contains(parent)) {
     DLOG(ERROR) << "Parent is contained within surface's hierarchy";
     return nullptr;
   }
 
   if (surface->HasSurfaceDelegate()) {
     DLOG(ERROR) << "Surface has already been assigned a role";
     return nullptr;
   }
 
   return make_scoped_ptr(new SubSurface(surface, parent));
 }
 
 }  // namespace exo