Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1819273002: exo: Improved implementation of child surfaces and popups. (Closed)

Created:
4 years, 9 months ago by reveman
Modified:
4 years, 9 months ago
Reviewers:
Daniele Castagna
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Improved implementation of child surfaces and popups. Use transient parents instead of making child surfaces direct children of parent widgets. The result is correct stacking of surfaces without locking child surfaces into the parent surface coordinate space. The ownership of widgets has been moved to the native widget so that destruction of transient parent is handled correctly. This also fixes an issue with popup surface position. The visible bounds of the child surface was not taken into account correctly. BUG=549781 TEST=exo_unittests Committed: https://crrev.com/d4372178c9652339528e915d83139d50cdd1de24 Cr-Commit-Position: refs/heads/master@{#382491}

Patch Set 1 #

Patch Set 2 : fix deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -56 lines) Patch
M components/exo.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M components/exo/display.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/exo/pointer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/exo/shell_surface.h View 3 chunks +8 lines, -2 lines 0 comments Download
M components/exo/shell_surface.cc View 11 chunks +64 lines, -48 lines 0 comments Download
M components/exo/shell_surface_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
reveman
4 years, 9 months ago (2016-03-22 01:00:49 UTC) #2
Daniele Castagna
lgtm
4 years, 9 months ago (2016-03-22 01:26:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819273002/1
4 years, 9 months ago (2016-03-22 01:27:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/160417)
4 years, 9 months ago (2016-03-22 01:50:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819273002/20001
4 years, 9 months ago (2016-03-22 01:58:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 03:11:02 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 03:13:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4372178c9652339528e915d83139d50cdd1de24
Cr-Commit-Position: refs/heads/master@{#382491}

Powered by Google App Engine
This is Rietveld 408576698