Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1819203002: Fix some issues with whitespace in formatter. (Closed)

Created:
4 years, 9 months ago by azani
Modified:
4 years, 9 months ago
Reviewers:
rudominer
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix some issues with whitespace in formatter. 1) Insert a whitespace after the forward slash of a single line comment e.g: //hello. -> // hello. 2) Remove whitespace above the first element in a container: struct Hello { enum Something { BLAH, }; }; becomes: struct Hello { enum Something { BLAH, }; }; R=rudominer@chromium.org, rudominer BUG= #592 Committed: https://chromium.googlesource.com/external/mojo/+/8feb9dcecaf79e92f5f9fea29cbe9091174bbe67

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -7 lines) Patch
M mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/formatter/printer.go View 7 chunks +53 lines, -5 lines 0 comments Download
M mojom/mojom_parser/formatter/printer_test.go View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
azani
4 years, 9 months ago (2016-03-21 23:45:54 UTC) #1
rudominer
lgtm but please wait for https://codereview.chromium.org/1819223002/ before landing.
4 years, 9 months ago (2016-03-22 00:42:54 UTC) #3
azani
4 years, 9 months ago (2016-03-22 21:06:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8feb9dcecaf79e92f5f9fea29cbe9091174bbe67 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698