Add tests for ShellWindowLinkDelegate::OpenURLFromTab

chrome/browser/ui/extensions/shell_window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/extensions/shell_window.h"
 
 #include "apps/shell_window_geometry_cache.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/app_window_contents.h"
@@ skipping 300 matching lines @@
 void ShellWindow::AddNewContents(WebContents* source,
                                  WebContents* new_contents,
                                  WindowOpenDisposition disposition,
                                  const gfx::Rect& initial_pos,
                                  bool user_gesture,
                                  bool* was_blocked) {
   DCHECK(Profile::FromBrowserContext(new_contents->GetBrowserContext()) ==
       profile_);
 #if defined(OS_MACOSX) || defined(OS_WIN) || \
     (defined(OS_LINUX) && !defined(OS_CHROMEOS))
   if (disable_external_open_for_testing_) {

[zhchbin, 2013/07/01 06:24:39]

Can we remove this "disable_external_open_for_testing_" and the following code,
it seems to be useful for the test case: PlatformAppBrowserTest.OpenLink only.
And here is some duplicated code.

     Browser* browser =
         chrome::FindOrCreateTabbedBrowser(profile_, chrome::GetActiveDesktop());
     // Force all links to open in a new tab, even if they were trying to open a
     // new window.
     disposition =
         disposition == NEW_BACKGROUND_TAB ? disposition : NEW_FOREGROUND_TAB;
     chrome::AddWebContents(browser, NULL, new_contents, disposition,
                            initial_pos, user_gesture, was_blocked);
   } else {
     new_contents->SetDelegate(new ShellWindowLinkDelegate());
@@ skipping 358 matching lines @@
     sk_region->op(
         region.bounds.x(),
         region.bounds.y(),
         region.bounds.right(),
         region.bounds.bottom(),
         region.draggable ? SkRegion::kUnion_Op : SkRegion::kDifference_Op);
   }
   return sk_region;
 }
 
+// static
 void ShellWindow::DisableExternalOpenForTesting() {
   disable_external_open_for_testing_ = true;
 }
 
+// static
+void ShellWindow::EnableExternalOpenForTesting() {
+  disable_external_open_for_testing_ = false;
+}