Issue 1819193003: Dart: Replace some asserts with exceptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1819193003: Dart: Replace some asserts with exceptions (Closed)

Created:
4 years, 9 months ago by zra

Modified:
4 years, 9 months ago

Reviewers:
Cutch

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Dart: Replace some asserts with exceptions related #724 R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/782e9f19c77cfdd13d1b5648d81693ead61b62c9

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -8 lines)			Patch
	M	mojo/dart/packages/mojo/lib/src/application_connection.dart	View		3 chunks	+26 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

4 years, 9 months ago (2016-03-22 20:58:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
782e9f19c77cfdd13d1b5648d81693ead61b62c9 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages