Disable CALayer overlays on 10.9

Disable CALayer overlays on 10.9

This is causing issues with PDF and print-preview for yet-unknown
reasons. Hopefully we can re-enable CALayer overlays when we find the
fix.

BUG=594343
Committed: https://crrev.com/52dd784270ee9386ceba4e29c198c86dea9912dc
Cr-Commit-Position: refs/heads/master@{#382498}

[ccameron, 2016-03-21 23:36:51]

ccameron@chromium.org changed reviewers:
+ erikchen@chromium.org

[ccameron, 2016-03-21 23:36:52]

There are requests to merge this into M49, so this is the smallest-scale fix
imaginable.

Hopefully I can root-cause this before M50.

[erikchen, 2016-03-21 23:42:14]

On 2016/03/21 23:36:52, ccameron wrote:
> There are requests to merge this into M49, so this is the smallest-scale fix
> imaginable.
> 
> Hopefully I can root-cause this before M50.

Hasn't the ship for M-49 already sailed? Are we really going to respin for this?
The bug you linked doesn't have a Merge request or any discussion with TPMs.

[erikchen, 2016-03-22 01:37:36]

lgtm

I couldn't reproduce the issue on 10.9, so I wasn't able to verify the fix.

https://codereview.chromium.org/1819193002/diff/1/content/browser/compositor/...
File
content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm
(right):

https://codereview.chromium.org/1819193002/diff/1/content/browser/compositor/...
content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm:44:
// buggy, see http://594343
nit: """https://crbug.com/594343""" instead of """http://594343"""

[ccameron, 2016-03-22 02:54:54]

Thanks -- updated.

On 2016/03/22 01:37:36, erikchen wrote:
> lgtm
> 
> I couldn't reproduce the issue on 10.9, so I wasn't able to verify the fix.
> 
>
https://codereview.chromium.org/1819193002/diff/1/content/browser/compositor/...
> File
>
content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm
> (right):
> 
>
https://codereview.chromium.org/1819193002/diff/1/content/browser/compositor/...
>
content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm:44:
> // buggy, see http://594343
> nit: """https://crbug.com/594343""" instead of """http://594343"""

[ccameron, 2016-03-22 02:54:57]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-03-22 02:54:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1819193002/#ps20001
(title: "incorporate review feedback")

[commit-bot: I haz the power, 2016-03-22 02:55:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819193002/20001

[commit-bot: I haz the power, 2016-03-22 03:29:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-22 03:30:12]

Description was changed from

==========
Disable CALayer overlays on 10.9

This is causing issues with PDF and print-preview for yet-unknown
reasons. Hopefully we can re-enable CALayer overlays when we find the
fix.

BUG=594343
==========

to

==========
Disable CALayer overlays on 10.9

This is causing issues with PDF and print-preview for yet-unknown
reasons. Hopefully we can re-enable CALayer overlays when we find the
fix.

BUG=594343

Committed: https://crrev.com/52dd784270ee9386ceba4e29c198c86dea9912dc
Cr-Commit-Position: refs/heads/master@{#382498}
==========

[commit-bot: I haz the power, 2016-03-22 03:30:13]

Patchset 2 (id:??) landed as
https://crrev.com/52dd784270ee9386ceba4e29c198c86dea9912dc
Cr-Commit-Position: refs/heads/master@{#382498}

[erikchen, 2016-03-22 17:23:38]

On 2016/03/22 03:30:13, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/52dd784270ee9386ceba4e29c198c86dea9912dc
> Cr-Commit-Position: refs/heads/master@{#382498}

ccameron: Patch set 3 looks totally unrelated. Delete it?

[ccameron, 2016-03-22 17:55:01]

Patchset #3 (id:40001) has been deleted

[ccameron, 2016-03-22 17:55:20]

On 2016/03/22 17:23:38, erikchen wrote:
> On 2016/03/22 03:30:13, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/52dd784270ee9386ceba4e29c198c86dea9912dc
> > Cr-Commit-Position: refs/heads/master@{#382498}
> 
> ccameron: Patch set 3 looks totally unrelated. Delete it?

I was wondering where that patch had gone.

[ccameron, 2016-03-23 21:41:27]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1830733003/ by ccameron@chromium.org.

The reason for reverting is: Wasn't helpful..